Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Apr 2020 13:02:42 +0800
From:   Orson Zhai <orson.unisoc@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Jason Baron <jbaron@akamai.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Randy Dunlap <rdunlap@infradead.org>, orsonzhai@gmail.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        kernel-team@android.com, Orson Zhai <orson.zhai@unisoc.com>
Subject: Re: [PATCH] dynamic_debug: Add an option to enable dynamic debug for
 modules only
Message-ID: <20200413050241.GA5694@lenovo>
Mail-Followup-To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Jason Baron <jbaron@akamai.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Randy Dunlap <rdunlap@infradead.org>, orsonzhai@gmail.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        kernel-team@android.com, Orson Zhai <orson.zhai@unisoc.com>
References: <1586521984-5890-1-git-send-email-orson.unisoc@gmail.com>
 <20200410124414.GB2091460@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200410124414.GB2091460@kroah.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 10, 2020 at 02:44:14PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 10, 2020 at 08:33:04PM +0800, Orson Zhai wrote:
> > From: Orson Zhai <orson.zhai@unisoc.com>
> > 
> > Instead of enabling dynamic debug globally with CONFIG_DYNAMIC_DEBUG,
> > CONFIG_DYNAMIC_DEBUG_CORE will only enable core function of dynamic
> > debug. With the DEBUG_MODULE defined for any modules, dynamic debug
> > will be tied to them.
> > 
> > This is useful for people who only want to enable dynamic debug for
> > kernel modules without worrying about kernel image size and memory
> > consumption is increasing too much.
> > 
> > Signed-off-by: Orson Zhai <orson.zhai@unisoc.com>
> > ---
> >  Documentation/admin-guide/dynamic-debug-howto.rst |  7 +++++--
> >  include/linux/dev_printk.h                        |  6 ++++--
> >  include/linux/dynamic_debug.h                     |  2 +-
> >  include/linux/printk.h                            | 14 +++++++++-----
> >  lib/Kconfig.debug                                 | 12 ++++++++++++
> >  lib/Makefile                                      |  2 +-
> >  lib/dynamic_debug.c                               |  9 +++++++--
> >  7 files changed, 39 insertions(+), 13 deletions(-)
> 
> Crazy idea, I like it :)

Jason was highly appreciated for his suggestion to my RFC patch before this.

> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thank you very much.

Best,
Orson