Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750815AbWB1IZL (ORCPT ); Tue, 28 Feb 2006 03:25:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750902AbWB1IZL (ORCPT ); Tue, 28 Feb 2006 03:25:11 -0500 Received: from ozlabs.org ([203.10.76.45]:22978 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1750815AbWB1IZJ (ORCPT ); Tue, 28 Feb 2006 03:25:09 -0500 Date: Tue, 28 Feb 2006 19:24:17 +1100 From: David Gibson To: "Zhang, Yanmin" Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , kenneth.w.chen@intel.com, "yanmin.zhang@intel.com" , davem@davemloft.net, paulus@samba.org, benh@kernel.crashing.org, wli@holomorphy.com, lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, "tony.luck@intel.com" Subject: Re: [PATCH] Enable mprotect on huge pages Message-ID: <20060228082417.GB20963@localhost.localdomain> Mail-Followup-To: David Gibson , "Zhang, Yanmin" , Andrew Morton , "linux-kernel@vger.kernel.org" , kenneth.w.chen@intel.com, "yanmin.zhang@intel.com" , davem@davemloft.net, paulus@samba.org, benh@kernel.crashing.org, wli@holomorphy.com, lethal@linux-sh.org, kkojima@rr.iij4u.or.jp, "tony.luck@intel.com" References: <1140664780.12944.26.camel@ymzhang-perf.sh.intel.com> <20060224142844.77cbd484.akpm@osdl.org> <20060226230903.GA24422@localhost.localdomain> <1141018592.1256.37.camel@ymzhang-perf.sh.intel.com> <1141022034.1256.44.camel@ymzhang-perf.sh.intel.com> <20060227173449.26c79a44.akpm@osdl.org> <1141097034.3898.10.camel@ymzhang-perf.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1141097034.3898.10.camel@ymzhang-perf.sh.intel.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1842 Lines: 46 On Tue, Feb 28, 2006 at 11:23:54AM +0800, Zhang, Yanmin wrote: > On Tue, 2006-02-28 at 09:34, Andrew Morton wrote: > > "Zhang, Yanmin" wrote: > > > > > > > > > > 2.6.16-rc3 uses hugetlb on-demand paging, but it doesn_t support hugetlb > > > > > > > mprotect. My patch against 2.6.16-rc3 enables this capability. > > > > > > Based on David's comments, I worked out a new patch against 2.6.16-rc4. > > > Thank David. > > > > > > > Please always send an updated changelog when sending an updated patch. > > Otherwise I have to go trolling back through the email thread to find it, > > then work out what needs to be changed. > Thanks for your kind reminder. I would do so next time. > > > > > > > > > I tested it on i386/x86_64/ia64. Who could help test it on other > > > platforms, such like PPC64? > > > > I can do that - please send me your test app? > I attach a test case. It will create directory /mnt/hugepages and delete it > after testing automatically. > > To run it by user root: > #gcc -o mprotect_testcase mprotect_testcase.c > #echo "5">/proc/sys/vm/nr_hugepages > #./mprotect_testcase > > You could use gdb to step it to see the changing of the process vma maps. I've just added a simpler testcase than this one to the libhugetlbfs testsuite. Both R->RW and RW->R transitions appear to work (I haven't tested EXEC transitions yet, that's hairier). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/