Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp" 
        <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
CC:     "Mori.Takahiro@ab.MitsubishiElectric.co.jp" 
        <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
        "Motai.Hirotaka@aj.MitsubishiElectric.co.jp" 
        <Motai.Hirotaka@aj.MitsubishiElectric.co.jp>,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Sungjong Seo <sj1557.seo@samsung.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'
Thread-Topic: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'
Thread-Index: AQHWDXnb7kFzLdIDe0GisWVV38Nr1KhvFNoAgAenMeA=
Date:   Mon, 13 Apr 2020 09:41:22 +0000
Deferred-Delivery: Mon, 13 Apr 2020 09:43:00 +0000
Message-ID: <TY1PR01MB157894A971A781BE900C5A7590DD0@TY1PR01MB1578.jpnprd01.prod.outlook.com>
References: <20200408074610.35591-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
 <20200408112152.GP21484@bombadil.infradead.org>
In-Reply-To: <20200408112152.GP21484@bombadil.infradead.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: dc.MitsubishiElectric.co.jp does
 not designate permitted sender hosts)
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1139211b-162b-4bc6-6c27-08d7df8f1784
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2020 09:43:16.3486
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c5a75b62-4bff-4c96-a720-6621ce9978e5
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YW5qVCCdY1Kx6D7mMWVh+F9X4EHPUHL6x1ZQFp0/MsIuqd8hjZhW31xPTmphOovxtzuEejIbbaMjCnrkZKQZBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR01MB1852
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Please leave at least 24 hours between sending new versions so that
> you can collect all feedback relating to your change, and we don't see
> discussion fragment between different threads.

Thanks for good advice!

> > +		ts->tv_sec +=3D (time_10ms * 10) / 1000;
> > +		ts->tv_nsec =3D (time_10ms * 10) % 1000 * NSEC_PER_MSEC;
>=20
> I find this more confusing than the original.

The parentheses were intended to group conversions into milliseconds,=20
but were not necessary from an "operator precedence" perspective.


>=20
> 		ts->tv_sec +=3D time_10ms / 100;
> 		ts->tv_nsec =3D (time_10ms % 100) * 10 * NSEC_PER_MSEC;
>=20
> is easier to understand for me, not least because I don't need to worry
> about the operator precedence between % and *.

If I use '100' for the divisor of '10ms', I find it difficult to understand=
=20
the meaning of the operation.

When using '100' for the divisor, I think cs (centi-sec) is easier to under=
stand than 10ms.
Which do you prefer, time_10ms or time_cs?


BR
---
Kohada Tetsuhiro <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>