Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3440537ybb; Mon, 13 Apr 2020 08:08:32 -0700 (PDT) X-Google-Smtp-Source: APiQypJn+wi5Fkj3bOj0tWVo273VnGFCh5qlYze2vk+UAdP0bIJ2EzEWqir1jDpQPJYYsD0448yU X-Received: by 2002:a05:6402:1485:: with SMTP id e5mr16761157edv.239.1586790512074; Mon, 13 Apr 2020 08:08:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586790512; cv=none; d=google.com; s=arc-20160816; b=cyE1u2kB1q7A1yWDNK0VxqJji5qsPQODPxgWI3CjxKI0oRjLgIqSH9Jbt9cse9edHl c97MH8nflm0yCzkBpzo8Y1GmI8i2tg+9IiLJYP46l61ybYc6tIAUK7Isi2NQ9Z2Ktvb+ LTZapc/wuxr2WuZk+AfaZoJ3tA5STFEtdwXDuBZuvXHaijYwVknCEIYoNP/KcpTcz0gj su7raNZOQRUqvlW2Xjn8VAgrDyT61QpRCIaK4a++RQ4FR2VHoJn9r6LPMD6jm3s9SywY Sb5yThuclYyQtk7n+pY0eyDURL99henE9Jv1F9cSoimZrx0qoQeRsQjOzltEcaOgLhoI EqrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Yn9moHjVbcUPSeaj77KPZLl/vQez8JJtxvZDsLkgp90=; b=dR+d14vhkKZcv3SEyu6bkKuj2oBHciFdJ0PKtQROfOTlf00tKfECXc34NO/WwCQqyl +BYCh5VIQoc4s4t3n/vu4+zw483hdMlQpCSDDXVXSvYg4ipybgYqxXHFuEuc2NaXAP3W Wyfs8k6z79AOYHqsINh6kl+2fyA+uflBbTGU9dkqhcS7zLG6du+SVX1AU0gWcjJagOAe IzG7VEvmO/Fiy9AUUzAmnOkPsZJd8MOv5btXrNav8VdfM+xZCsAuI4AxkjUKOPe6xVax SgCpColUaY2N1EYdZGMTzMdlxFEmUUySC2Y+JqnxfLonrXTCI5HCfs8bxZS0pmOety4/ vJcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UIyn+Yvv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec19si6651133ejb.436.2020.04.13.08.08.07; Mon, 13 Apr 2020 08:08:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UIyn+Yvv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729632AbgDMM4V (ORCPT + 99 others); Mon, 13 Apr 2020 08:56:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:54012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbgDMM4U (ORCPT ); Mon, 13 Apr 2020 08:56:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F5D32073E; Mon, 13 Apr 2020 12:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782579; bh=pOHGZCZoW07Fu0ZaWxLsnPUSYtIXpjWkuH7RiI5DFEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UIyn+YvvNp3XP2ZY9H48InOqBSeOQz8L/OifYCLhKB6CyH2fpiKQS8af0VPcAUxBY xCeLHhNcvuBibTruRDfVyZC14nU96OLzB6p8nC9bntommQGDCvgJ6vtynQY8upow3q e91G7+4P+L3tt5Cn6PcfUMVuMw+OZ5QI5j14x1uE= Date: Mon, 13 Apr 2020 14:56:16 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the phy->signal variable Message-ID: <20200413125616.GA3127208@kroah.com> References: <20200411122610.7901-1-oscar.carter@gmx.com> <20200411122610.7901-2-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200411122610.7901-2-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote: > Create a constant array with the values of the "phy->signal" for every > rate. Remove all "phy->signal" assignments inside the switch statement > and replace these with a single reading from the new vnt_phy_signal > array. > > The constant array can be of one dimension because the OR mask with > BIT(3) or BIT(4) allow obtain a second value according to the rate, > the preamble_type and the pkt_type. > > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/baseband.c | 105 ++++++++---------------------- > 1 file changed, 26 insertions(+), 79 deletions(-) This series did not apply to my tree, please rebase and resend. thanks, greg k-h