Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3441249ybb; Mon, 13 Apr 2020 08:09:12 -0700 (PDT) X-Google-Smtp-Source: APiQypLLJgbAfpcDySfYRrUd4m8pGjRVgsNFiCrKW9V1nj9Q1eATV2lbkxJOf6KlAsCf+j8yHpl4 X-Received: by 2002:a50:8e08:: with SMTP id 8mr17121518edw.153.1586790552226; Mon, 13 Apr 2020 08:09:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586790552; cv=none; d=google.com; s=arc-20160816; b=BmLY2wcvCrt271UmKry/Gx6+NsogJZaSQB/HQthR5mnrttnx4Y4EF8BKSnz/sLtxDN gSqK9g1IhrY9p+VV5HMPNWkcT7TxwqCZczqs2mseeL6D5JbT0oqu2Et7CpQbIFz2kUyB sMZnURVuymvxlGz0Z6fh56QLXdg1OeD7ZFq5PYWXESA8EWjIjSl4Sp3DKZf82BS9U7F5 S1a672M4RRiKi/bWUyvCY5MZb9bU5hYyyBZy52rx2/kLMIxpgnngYIPPLiZvgahEIZkZ npEfPtYzo96PC8qoocMrhde/HXyUMlsflXuneGOMKAqnvSj1N2kB8wYXNcHXIvc0L49J hnKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jXRCwNorzrmx8uM9TgXV2e+pg8TPG/zUfJzn1XRRm4Y=; b=RXQiwOo+LXbrQL20e4O2zF7EkUQCZJ0YSs9GhdlUS6MXsP2SSCryXldo97YrKb1bXv XM8HyJBCQoanXRu6n2ZGeqVCT5aMpBHjeD4PjkAfO/jEQQ8PbNa0oWXWeG7SlU87OjCn bSJFfJ/hNJh1LiHJEAeKTAaAZ25XCaBE3KD1pmCILniwgXM8qZYaF8oGP+aACrNJQtnP Npxx/m1PJN2AGzvSsPvVvyQ28KgfXNpTieteyZ0t6gghcTOHcQkK3us7A4H/cCaV+iXf 4IwymnQP5vFaSIemfW9N45YPrtTSqvzAB2IGH7p/M+63PdBHaN9vak6bA3gNLMwQFflX IUmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tTmxOG7c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si7338364edl.361.2020.04.13.08.08.41; Mon, 13 Apr 2020 08:09:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tTmxOG7c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729641AbgDMM4i (ORCPT + 99 others); Mon, 13 Apr 2020 08:56:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:54096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbgDMM4h (ORCPT ); Mon, 13 Apr 2020 08:56:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 905562073E; Mon, 13 Apr 2020 12:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586782596; bh=18DKhHBYMozZ6+lW7jqDESjmUuzWD027T7nLZuXSulA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tTmxOG7cTpjaO4DRNXaaDdmdKQtm89+iOD+zLf1aCkTwZxOxH8gXDbS9iRfXk01dy UycFw0/GDO0TPtsqoYBFlhTgMhP4V8FzXpviTcCUfPm4ZGHFbzN16V3AdWFhT4UAh6 W1JCrSLvHOdfJwTdjnFYdEPjFvZb7faavh4D2alI= Date: Mon, 13 Apr 2020 14:56:33 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH v3 1/2] staging: vt6656: Use define instead of magic number for tx_rate Message-ID: <20200413125633.GB3127208@kroah.com> References: <20200407163915.7491-1-oscar.carter@gmx.com> <20200407163915.7491-2-oscar.carter@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407163915.7491-2-oscar.carter@gmx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2020 at 06:39:14PM +0200, Oscar Carter wrote: > Use the define RATE_11M present in the file "device.h" instead of the > magic number 3. So the code is more clear. > > Reviewed-by: Dan Carpenter > Signed-off-by: Oscar Carter > --- > drivers/staging/vt6656/baseband.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch did not apply to my tree, please rebase and resend. thanks, greg k-h