Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3462485ybb; Mon, 13 Apr 2020 08:33:34 -0700 (PDT) X-Google-Smtp-Source: APiQypLB/aXtbf4Xhiqu9t6ryLg95TbPGb12O1w9P7VD/eFs9KiOrS6HXLSPVGCGFBrsfZ2pWaH8 X-Received: by 2002:a05:6402:d4:: with SMTP id i20mr16423633edu.115.1586792014434; Mon, 13 Apr 2020 08:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586792014; cv=none; d=google.com; s=arc-20160816; b=ni4l2roSAYKnqGHmz9kjEUpTtTUco3eu0uRrBi7Kz7Hj5ZihahA5w9q1fRREoc2Unf r31C3QguA5xIMVLFgUYgM2C+11T/DHfR/1zgheuAfzwvl4dLZ5970oUSpin5jH8CS9IK t/HFqajC3nRg0da3C7XT5SOnPrYMBOH8aCMThenOr9RDh6LXWR515JWYxZ2/0mcFD+TQ YA4nQM9vgxAlDM7XXBL+SfcnYH6URDKFK/rKZD5e/BJldGg4lgg/0G/OqG38sJrfWF+5 ZTg1fdBBhqYY29NCUU3kDs23gdF4RIsfuvNfVamG58m2kVStYRQ0c88DXsm+XyIUVaOg 8zMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=v4KoAVObDlu8zDziL74/SjVeK8XVcCTlPr1Rw0ASvGQ=; b=U928bSb8wusDhT5sDi58waDwNgLWU1lS7Z9b53kR9n4wAd96n8165oq6viF/z3xHnB OPsH5GOmaJIeIu1MqDLwcXzShwRD9Ez1T7rT1BVNg2t9StRBoUqY6RtiuRz93A8EWYF9 P0ncktVZoVpOo4PrUQlv/0cN+a4UUEkDcnEo5XtJ/OstOww4hcDJODKKlM+hPGbfcN8Y 4eKnnOYmBgxeSjQ/UTu5ARis6FWa0NzlHkQ7Vn4yVWGLmzo97J7At6GKoocXziXdsAiM THI7caiPsNbl6YcetUdaBtWWWEj94aa5V0MuunwuJsF1LjJ/g9KbNyScUHXUpUbtEeDY BIiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=KSKUCpzM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si3724261edw.490.2020.04.13.08.33.09; Mon, 13 Apr 2020 08:33:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=KSKUCpzM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730771AbgDMOZZ (ORCPT + 99 others); Mon, 13 Apr 2020 10:25:25 -0400 Received: from mout.gmx.net ([212.227.15.15]:41043 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730636AbgDMOZY (ORCPT ); Mon, 13 Apr 2020 10:25:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586787920; bh=unSxpRsDMlSBh+KoqlcyvwQe1MQ6kpwfYI9Sofambco=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=KSKUCpzMYxIDjfTfAXxreQwd8mrMmlmXg5LToQ+gbJUTfOu+uaTgZhjRykAkrsYtf JJVUHiUGuDIJLonU38hHVdjlEOugNHKVOyYv+dEZea4RajEls9Z9R30YOiTQdAaQZb VgceuapE7AidmTxFQHO0iv5Gp4RTovZrkKqFkIb8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ubuntu ([83.52.229.196]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MPog5-1jbw6u3ZK7-00MuTb; Mon, 13 Apr 2020 16:25:19 +0200 Date: Mon, 13 Apr 2020 16:25:17 +0200 From: Oscar Carter To: Greg Kroah-Hartman Cc: Oscar Carter , Forest Bond , devel@driverdev.osuosl.org, Malcolm Priestley , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the phy->signal variable Message-ID: <20200413142517.GB3101@ubuntu> References: <20200411122610.7901-1-oscar.carter@gmx.com> <20200411122610.7901-2-oscar.carter@gmx.com> <20200413125616.GA3127208@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413125616.GA3127208@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Provags-ID: V03:K1:sePqCH0veJcZP+UIPEJ20g1Mqu5U4j9dYnY8IkxX8Q47yMA7N/8 Wy/a1qW5CHeJCk6ifgR5vVx2PyXdvmAfWxZDj4gd/9c8rBiqy+ao1FhmoBa3HhQCOa28/s8 dFFGhHn4Gs/vk8ozR41que6OktruwYTZcr64xHy16rB7Js/Srj3fq/2rUZFxW6/ai5+g04U yBh/g+Fau6fxGBmwbhqMA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6wRIMaxwNqc=:hcxYmiiQ7Sp467P4jDYvMO 9xiS2Jevx9BkqYY5WJUDUzDiFTSa/K68mp5bPWOzNaq2RuAzq+D5H4vVsgGyLmzih9uRqtmkb 1qbnc1ojp0rYNkenfRSgKPGixOZmc6IaxfaHp+eMA4dDY7ZWEKTXPpBcvnLDGMiORt3fCgHv5 /t/cKyRWMaoGOPRBRMwc5M51ULkfLSs5lZRdfYbrxAnbOImcaNZViQ4KPBlR7FXprTSZTc8gK /sH7j8Qh4bT/PoZh3cZl9mw6PKpsVrtUQ8SASmH8/Iv+tW+qmeyU0aqGeJCL2Yx5REUiHN4W3 G4J/Xw1XdZT3r7NARiBJqqQwPRWg4XL6m+lBWtmXr/E9SPCCvFkldXe8HRR9dmFE4gsn5CvGs n8qNcH8aviSL5eKxYuhnFM99eyJN+zF+BRI0UQVKyK7hG49Q5i06bd/vHmS31pZjDDz3lxnGF mqVIAuyKcGCtoLiEOoOLfD0RPIRsAPZlbrvso8PuAfvlTmJ2n+4h62nmF/IF/nOQYqESX1QMG 0A0/zp50tSdAiWnTfpo8rseW8lSGahkQR7ABJuvWsqNF7Amsyd7hXuXsmjlkezXEsbbUBdZpw uAGCkTC3UeQA/y8/g86kpL0QeP2v8XsZNg8Q9/AjzFJITNpbmh+c9hspE31swIQy5YY/7hqW1 VTwbSz+Q61cx5nQ2QCvOPzDxgUl2HV51p/+Ak9GuqBANj0rCZehRl4itkElk14WomNjVahYQf wBbdcPUEllczahbWu4j1HQkYWEN7EvZqt7oooDQf1FPrqeOymYaB14DP9J0S+5n513uR4zKV2 kZ82CuBpt+vTJTKQGEvArwwwgsmdOC71AmiyPpk1du7Vqo52QGEklb9Q3BRWeAoKQWVz7V4mw uvTITLacjbP4C47G0M7gRTqPbL8fvN3im7iCLKp8f06Ekt+NaYg7VwJHuIXfjVduBC4ZgVTHm Zl/5RFWoG0fL9/mx2p81AvV+4Mw3wghmOxEPaz5DKScldeKo8AqhJbg/9C+tovnPOG0TPT5Vp Q+gFBEaHxq3+QZq/E2aAo3x0NHBfD53GInxm+IMjVL42IURkkOUvOQS68afXjNn57j1sLM8/Q gAZPnfAWaz2hD5Kd9KZuEQLGtXiAjVYSnTTXPZUWnr2jSKuBAhiODe/i95kg0w/BOgD6qSoyN OzzsvtqQt/V97nPtuQdDJPHU01Bur5UyPMSOoW4HKWqq1PF8PjhoOH0ADdhu3RarPU62MpApY Y40pplkhJvTTzDcQc Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote: > > Create a constant array with the values of the "phy->signal" for every > > rate. Remove all "phy->signal" assignments inside the switch statement > > and replace these with a single reading from the new vnt_phy_signal > > array. > > > > The constant array can be of one dimension because the OR mask with > > BIT(3) or BIT(4) allow obtain a second value according to the rate, > > the preamble_type and the pkt_type. > > > > Signed-off-by: Oscar Carter > > --- > > drivers/staging/vt6656/baseband.c | 105 ++++++++---------------------= - > > 1 file changed, 26 insertions(+), 79 deletions(-) > > This series did not apply to my tree, please rebase and resend. Rebase the patchs is a normal process in the development or am I doing som= ething wrong ? > > thanks, > > greg k-h thanks, oscar carter