Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3463420ybb; Mon, 13 Apr 2020 08:34:37 -0700 (PDT) X-Google-Smtp-Source: APiQypIhfx2wDVwnEuFDR4Nmdpe57/MCreEBVLE4IDXE81w/wffaLvb2F3vFGUZTpjSIl2hmwzKr X-Received: by 2002:a17:906:1845:: with SMTP id w5mr15781114eje.287.1586792077553; Mon, 13 Apr 2020 08:34:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586792077; cv=none; d=google.com; s=arc-20160816; b=E3yPwy9aVCWvjndvdZHaf+efuJnuKcd76bwPRgVnpo7AWNOI0ww1E5Puy2PkO7pRs3 5jV/w91shptg699GGS+mSdrsfO9lUCntfF3Jc5kjw5EuoWCsEm11CYT01IJKhYRtweko o/RDgaRm2TlTenB2xxMDQUy16oVbPJvdbK5y5NJjsE6s3BoBw1eYkOixtPw6N9id+bow GIHRkYvnNfsYVisghEJunC+bC8niaJRAGaOyWbw2Zu1Kpku4Eg4KzOgqsMpNuPyzk/E/ sFZZoU6p431KviolNqpXbQVBidK0EabCJYXd0AQQAeX6pYHKTrhgkjp9i8GXmT4LmFgw ZUGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=PFtR5Cdlb0XkUzRTLS8We39EWckSnSd5X/1ht1KE5dM=; b=fsTBzAVyKUZuPks/y0sBbWRgKSvuF49lgolKq9R3Fz91XEQzML5Vsro8/JOjPi6bMu Da6aag+ZwM69wgJHwWadGTu9R2u8HYvpFFTQ9Y0DJ7zD9OoneRFHWVHvS42zdB8anmSk a792bOZNh8oAAkJmO70JP925Pzyxg33G/TLDCHfJVhaeeZ/LAnfwcLSr9Y7PqlbuGX3l li5ssq4NmFYh2lBNjvXO9YP4jTuW0D3eFzx96vOSFb2WOHrSUtrOcFbjO40OFIHjoAT1 rl4hS01qx9N+nHhKtA4lcH/mUvXe0FiWyVzW71cdE0wj6zsUCbGHcvAvKzHMx6yF4OtD Nadg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cPUYRHSR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c2si7283809edx.82.2020.04.13.08.34.14; Mon, 13 Apr 2020 08:34:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cPUYRHSR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730813AbgDMOdB (ORCPT + 99 others); Mon, 13 Apr 2020 10:33:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:53482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728185AbgDMOdA (ORCPT ); Mon, 13 Apr 2020 10:33:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD30A2072C; Mon, 13 Apr 2020 14:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586788380; bh=UgsFITWUZlPhGRKvUFEzShkg0Dx45Ysmuw2lAc+SDaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cPUYRHSRHlx2GAXRo9nMBHjuEpgHckiq3M2LmlISBBRoqZH/M+444UvfX7V5w+lem 12kt52rKzHQvF8XkB9Ipm1InslQuuJvYlHydBBV5htlnSH2LJ9I4j3Ld5cQI5GOKbN YtPX5TEJFVDVOOU5ObxpHQvBduqAQLhbnLZAPXlU= Date: Mon, 13 Apr 2020 16:32:58 +0200 From: Greg Kroah-Hartman To: Oscar Carter Cc: devel@driverdev.osuosl.org, Malcolm Priestley , Forest Bond , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the phy->signal variable Message-ID: <20200413143258.GA3551837@kroah.com> References: <20200411122610.7901-1-oscar.carter@gmx.com> <20200411122610.7901-2-oscar.carter@gmx.com> <20200413125616.GA3127208@kroah.com> <20200413142517.GB3101@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413142517.GB3101@ubuntu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 04:25:17PM +0200, Oscar Carter wrote: > On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote: > > On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote: > > > Create a constant array with the values of the "phy->signal" for every > > > rate. Remove all "phy->signal" assignments inside the switch statement > > > and replace these with a single reading from the new vnt_phy_signal > > > array. > > > > > > The constant array can be of one dimension because the OR mask with > > > BIT(3) or BIT(4) allow obtain a second value according to the rate, > > > the preamble_type and the pkt_type. > > > > > > Signed-off-by: Oscar Carter > > > --- > > > drivers/staging/vt6656/baseband.c | 105 ++++++++---------------------- > > > 1 file changed, 26 insertions(+), 79 deletions(-) > > > > This series did not apply to my tree, please rebase and resend. > > Rebase the patchs is a normal process in the development or am I doing something > wrong ? It's normal when multiple people are working on the same area with lots of patches flying around. Not a problem, it doesn't bother me at all :) thanks, greg k-h