Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3463879ybb; Mon, 13 Apr 2020 08:35:11 -0700 (PDT) X-Google-Smtp-Source: APiQypKN7nU/7QWg5+hi923TYLCt0TgQdO2wBfUPirV+WPJ/KvLiW8grTme7ypDpVDSatnDd91OK X-Received: by 2002:a17:907:20ce:: with SMTP id qq14mr13839454ejb.10.1586792111259; Mon, 13 Apr 2020 08:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586792111; cv=none; d=google.com; s=arc-20160816; b=R/GBvdhQcDMXOVGuWaQ/Xkxr8SSPEb6/9dSeHnKkqFVQwnTv6mY9njZ0FdIYmMW8mc nd7kIlnDzHqVKG6cD302j3kCTsLY+dLi0SOeSqptLRXYv8mfK+V1XQ+FzqbSI1WotKHx emwP8jhD8E2dbfTVEwwzmsKJEk5oFfrVP29Gh0eWUfvcGOtpqmYO4a0J4sl5qi0Zi8cK e8L1zPzDjWWdn8GGdpgZ/nJfCfpgQ/YeanveI0H2PQ44dh1Il9WEHrKkS55Gs8jKIz/a Y98wbjcdYCRlVSUult68fM0fKEvodOFfLcNxKqIFjSPWBa+NGvSVE8HLyeqn95hW4bis uyGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=h+XGFsgPfd20MDxR04d7owdp4Iyf3Vpp6QD657FACmw=; b=Q16zKpkE8kIdHZ58TCzsmyNJz+8QBTIPZjqdRp9Lt4hueAsQxrFyr8NE8ND7WonAjk 8mj5pvMzEHLRuve1a7ARSxO7fXveBvklaQp6mUFRNaPZtei8FWbBYHQcX9TmthOCkwhb X8ZHZA5TCaGzw3YKvaVbG7ruAb8SvTuLP56u1I7552xpHn/J2oL329e9YatVfcOTzEFJ JofK8XEFMex1I4Sih6pITB1kBOcLF0RqDcoEtB7G6BNvNr4O518nT1l94Gfd2Qc7aXug Raa3Rk2x59UNIDgDOfzTv1598SJSrPzfzhwPYVPtuga1K3vGARQSlLEO4T+zSssjz991 w8GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=k145ZrB3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si7065785edq.15.2020.04.13.08.34.47; Mon, 13 Apr 2020 08:35:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=k145ZrB3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729024AbgDMOng (ORCPT + 99 others); Mon, 13 Apr 2020 10:43:36 -0400 Received: from mout.gmx.net ([212.227.15.19]:32973 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728557AbgDMOnf (ORCPT ); Mon, 13 Apr 2020 10:43:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586789010; bh=0NCp+Vu36UV+Nep7pt3qtDDxRFXYEp54QmwUoOr/Bus=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=k145ZrB38WQIg90rT/myfy+BJRKoj2VMD+UkQl8+umJBjMzgqyN7kSodXMcd9f7MY Mp0t0O8Cd7kC9pOKdoqL8/EWkJTYLcYiXKHoiDmGDGFs6l0PIKR0JeMCUUFOxC8HNf mCBZCi1pIzBcWFvnxgFO/WsOgp13N2r57CPhsQR4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ubuntu ([83.52.229.196]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MLzBj-1jfoJ9109R-00HwcM; Mon, 13 Apr 2020 16:43:30 +0200 Date: Mon, 13 Apr 2020 16:43:28 +0200 From: Oscar Carter To: Greg Kroah-Hartman Cc: Oscar Carter , devel@driverdev.osuosl.org, Malcolm Priestley , Forest Bond , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the phy->signal variable Message-ID: <20200413144327.GD3101@ubuntu> References: <20200411122610.7901-1-oscar.carter@gmx.com> <20200411122610.7901-2-oscar.carter@gmx.com> <20200413125616.GA3127208@kroah.com> <20200413142517.GB3101@ubuntu> <20200413143258.GA3551837@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413143258.GA3551837@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Provags-ID: V03:K1:GuMtJNikT7pEfs4/zNmaUdOgAvOacWcwwOOhytyCJSV9BYLhUfL kxaLu3dMC1n5UErexfEQpc8R9urBLUIOg/7w4wRspq28pXeUDUEatKEIvVuv5QPWmwFNUm/ p0pMwnwSooeASoGzgpIPc+mg2Prw1yYkmJWAQvNYztU8G2Z/XDj8whE8H9nra14/nW3GENK Yw7i4mmFUUfcxppnj3eGQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bjWEYbs8t+E=:LX7PI3mdFcGUTYfUB6shCu CwdHYh6OmqCF3GIOxuUzU7XywQZNZ9lF2IXPJbIm4rxE73d8fZrLJ0b/H4CobdwIWym3JoBiY r8bk5x/+ImhWT+njsntCiEervMp1QI91kLo7jVM/RqqKnTCqFI+oqOQBARPe6yGsyxROaLaY4 XZWh8UMHOyh59qx8/xf/ya2vsgjORtTk+iGN6ABv5ZikdMXm67a4KRO6KDeKQiLEaHUYKFSAq 6yONGkJx2sH55rH0MHvETKT5gBHetdgPzAt2hrLbIqSZkadOwt6olkWvubIVgSoea6fnA7Jwc tqAAHUhdHhm7mu8JHQXdn3avsyG308+T4ZsMqG4O52dNstJUW8C0nUpgUv29BkI0REDGzBRaJ 918sHu2flYAxyHl6L0p8oYr0d6PeOFZyxRa4vkNUagHG+cjYfcw0dG5iThz1qVKmXMB5VMmo2 nEcamVTDBBsm+POCEmWRkUzSnZfOJVL1uCvuxdmzmdN2sYx/WzU/Vc6f2mUoGOTMmt/ZVpzIe Ov5g6HQak96brV6u/zmGvRnTbTBp2ULoK4TzGDjZftEqWI5o6gk0XhW/JKFILrz22PJtB98RT RMH0pqBh27T5rLL1kTN+RKcCBjkWM6TA4TWzwbdkhKpz14iHaRcn8kOyNbvCoAo+KISFxMoDz qaP6MP8KzHIM/5z5UwgZjXKGKzGBgsMTOHLtCTlo/GiHFbhhEU6OdZYXSAVqnL54SjyPKvV8O yWRKRO56xO9cvSDc3NqqPgIppiIj6l0ON4p3+veLO/o3i51k7pyK9dJMsquK5qsX8a0ENmNM3 imKqAOZ9SM1fXItqZL1fmzcFNRStjMuiKUVHM1L5Fg4DnqC6Y77KJ3cc+m6UPMDceAo6nzwFz AkNgQXXVnxLPH4WdzVFP4zUhThH243K7JOSmk2RlbRgXIqc5N18PvbhuwjY30p51FTDTY0uAy Snh7hlOcWAg+wL6kdQ8Uyh/iZaHogbc90BFkKCTjwKk8ouMNw+Qz2ursrO+2DpAF9juMN/ao4 Z3+0vNPIsaAID27t79JZnJ3OJ87C481OTBWh9t7dwst4Cgs9LMjLesN0hNAYg1CsgdcNP42pV xmG8LEanCRytagh9Kvt220ofESAgQkiBjxuWB+v9TShoTZpbk1IXWnA1znE+Cjb6XsTw0QiDH hEbsHD8Yb7N+KR+qSLCW9jGMrjiISG2TGAzmBNwGb6ORkskm6l/7u9SeBjsyS6n26qtYdA/8Z S1YGw1D4HI4PGwl1W Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 04:32:58PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 13, 2020 at 04:25:17PM +0200, Oscar Carter wrote: > > On Mon, Apr 13, 2020 at 02:56:16PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote: > > > > Create a constant array with the values of the "phy->signal" for e= very > > > > rate. Remove all "phy->signal" assignments inside the switch state= ment > > > > and replace these with a single reading from the new vnt_phy_signa= l > > > > array. > > > > > > > > The constant array can be of one dimension because the OR mask wit= h > > > > BIT(3) or BIT(4) allow obtain a second value according to the rate= , > > > > the preamble_type and the pkt_type. > > > > > > > > Signed-off-by: Oscar Carter > > > > --- > > > > drivers/staging/vt6656/baseband.c | 105 ++++++++-----------------= ----- > > > > 1 file changed, 26 insertions(+), 79 deletions(-) > > > > > > This series did not apply to my tree, please rebase and resend. > > > > Rebase the patchs is a normal process in the development or am I doing= something > > wrong ? > > It's normal when multiple people are working on the same area with lots > of patches flying around. Not a problem, it doesn't bother me at all :) Thanks for the clarification about this theme. > > thanks, > > greg k-h thanks, oscar carter