Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3465140ybb; Mon, 13 Apr 2020 08:36:47 -0700 (PDT) X-Google-Smtp-Source: APiQypLNj8z9WoAIOsoeVvx5IdUO5PG822mNf5JaKxxtM8IphlxDrzF65WE3xdnShSE/rRACVIuE X-Received: by 2002:a05:6402:14c1:: with SMTP id f1mr4336652edx.221.1586792207298; Mon, 13 Apr 2020 08:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586792207; cv=none; d=google.com; s=arc-20160816; b=XSY7brsOMefoTDZIWcwVZochzN02+h6ShO+9Q6ZMZoTsG3RLq5ZNDIZ1iYd2Tx7MNA 3RdosNZ9pvJTUyA5AgdE5YkQ2B7Tmz1528KiU4ePW1WkNfq0YpUrK7roo8/Qz4uduSMU 8JOMdKSB3jesAKOnsy+esIBZYU1JwuVHuvMDmp0f6DGvRqsBqB6cYCKE/VwjuEREoKew AyUMmaCcVtFsKlyNAc7q6DLUxdbY8CHnRcD/d5RV08vlo+Z0WivOtjDm6wzPzvXZIeLh /M5+Lnh33xO9b0Ae3opIJEBtqR1fG1DBBBIgeeiiUgMJ2AtgyINTGqMeO/pUviuSDQuO u1zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:from:organization :dkim-signature; bh=FEtIYVJIpib0M0PusMaXJ2aHzJiehmLRM7Ty7t9FWBg=; b=aHvEUFTt3aWwvsLMJkLmCTo93t5giL95ASXG//knX+e1OhaTQhzJ3uhsvFB6oQUs9j wM5qnUy5CKpb1kYWZFM5ZQJyNLsVQNTKjeDrWC0yFPzKDml6VPjf8O7sMetX4NxLm9Tc AHkewx5wenRgF+lLwgEDzE7jrzyJr8zvyp5s6HFhW0XUxgxALToy2qNSfy8lm4d62SY0 m9niAso2w1rVg8f/M9Y/KMIbTe+ryxMv9n/tL4JGOhjONpYwVr7ahz2Dha9L71mapSgH k0gNazodaaB7YQjd3ta3cfaitqkfZ/IWd+uIJXClBGojBwZxNezcMsnCImihvETfnLme n0KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XS1Jz86a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do17si7064157ejc.266.2020.04.13.08.36.23; Mon, 13 Apr 2020 08:36:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XS1Jz86a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730867AbgDMOu0 (ORCPT + 99 others); Mon, 13 Apr 2020 10:50:26 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:28251 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729311AbgDMOuZ (ORCPT ); Mon, 13 Apr 2020 10:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586789423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FEtIYVJIpib0M0PusMaXJ2aHzJiehmLRM7Ty7t9FWBg=; b=XS1Jz86aEiEcFECbrEDmqLHTkOGMqStrQE+1K/O5AcDzx2+YeS406k73UneD1Ut5RWx5AK VAYxNjDe2kFbyCHGBSgLFYVaKj2Wwwt0xcFV+lHxyuKTaCkG690jfWR4Q/1DacJUky5uVu xy7VhMJ6KnhzQj14aIhytihg+21Yl5I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204--_H3N8V-Pwmh2DH0fsaWsA-1; Mon, 13 Apr 2020 10:50:19 -0400 X-MC-Unique: -_H3N8V-Pwmh2DH0fsaWsA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9B5C1005509; Mon, 13 Apr 2020 14:50:17 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-224.rdu2.redhat.com [10.10.112.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id ABEB1272A5; Mon, 13 Apr 2020 14:50:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: torvalds@linux-foundation.org cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [GIT PULL] afs: Fixes MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2940558.1586789415.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 13 Apr 2020 15:50:15 +0100 Message-ID: <2940559.1586789415@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Here are some fixes for the afs filesystem: (1) Fix the decoding of fetched file status records do that in advances the xdr pointer under all circumstances. (2) Fix the decoding of a fetched file status record that indicates an inline abort code (ie. an error) so that it sets the flag saying that it got an error. (3) Fix the decoding of the result of the rename operation so that it doesn't skip the decoding of the second fetched file status (ie. that of the dest dir) in the case that the source and dest dirs were the same as this causes the xdr pointer not to be advanced, leading to incorrect decoding of subsequent parts of the reply. (4) Fix the dump of a bad YFSFetchStatus record to dump the full length. (5) Fix a race between local editing of directory contents and accessing the dir for reading or d_revalidate by using the same lock in both. (6) Fix afs_d_revalidate() to not accidentally reverse the version on a dentry when it's meant to be bringing it forward. David --- The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f313= 6: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags= /afs-fixes-20200413 for you to fetch changes up to 40fc81027f892284ce31f8b6de1e497f5b47e71f: afs: Fix afs_d_validate() to set the right directory version (2020-04-13= 15:09:01 +0100) ---------------------------------------------------------------- AFS fixes ---------------------------------------------------------------- David Howells (6): afs: Fix missing XDR advance in xdr_decode_{AFS,YFS}FSFetchStatus() afs: Fix decoding of inline abort codes from version 1 status record= s afs: Fix rename operation status delivery afs: Fix length of dump of bad YFSFetchStatus record afs: Fix race between post-modification dir edit and readdir/d_reval= idate afs: Fix afs_d_validate() to set the right directory version fs/afs/dir.c | 108 +++++++++++++++++++++++++++++++++---------------= ----- fs/afs/dir_silly.c | 22 +++++++---- fs/afs/fsclient.c | 27 ++++++++------ fs/afs/yfsclient.c | 26 +++++++------ 4 files changed, 112 insertions(+), 71 deletions(-)