Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4051671ybb; Mon, 13 Apr 2020 22:44:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJqPMkxEVHDb571V7x0SAG7hjmSA8ZkTZ7n2Y0pNkU/Vzn6H345qnl1xyJX9SvbpXi+7g5Y X-Received: by 2002:a17:906:315a:: with SMTP id e26mr18690591eje.53.1586843052392; Mon, 13 Apr 2020 22:44:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586843052; cv=none; d=google.com; s=arc-20160816; b=Nmtubzbyz9Mcm3o2+idpETvgX5IDHNktm4aOlyvBPGc8liefcrO71UeBdvJB7v55ZI 4LhmvCjAcHf+NgGFmOeKKfqAI41fsyOmKK8/5zTs3t9LGNL97iFo7gLvybcE1DrxXbZz kej1T1GqMhipVTAqmFg2YG4iey3GoT/plU/71oJ2CUhPVgrk9q5/+IUrzq0Qgh+l92WA yoSgT6CofasEa9e5Pgrf3aYMaTl8IoiOPsmLYEE8tAhbjpkRQM9VT7usM2pPo101U8Kc xjjVoPp40mnzK9tqmXVoNgdGfYfCrq2X10iqmzJWbIYh0Y6MEjtnI1HA2D0CiRg0Mcu5 tC6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=GSsrE2g5l7BCRaLVbZWyy1dTf9NFSpt6SmL24Bp1W4U=; b=R8IIeZoPW/Oe1C+iO+tUupPiro8N0P4Q8r9e6Dc+vSoliK4y7aNfKLVY5Aye0GursY 5PfDqa6iXr1huItKwi0ke7saMyop4zv5JxHxbTnze1ShR4MbExVd2LrtfFMo0GJZjceZ mCaVJcyne9Uwt0vWJ4vx05KrvF1wRAHYCLg+yjZorznIB/yoZCtsqCr7J2QEMXgGD5dm RpOdVMil92whT2WQ12FWKStxWlg5bGIs2BhmnZKZB34Rpa14oW2AOxAvLRnpw5BiERVi vdBLDSEy6XQqbBEGptiyRE0/XvQbEiOwYrmR2U9+aV6p8ezRCsqeWPaPABD6aklymEgZ zivg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si7308687ejf.121.2020.04.13.22.43.47; Mon, 13 Apr 2020 22:44:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729095AbgDMLi0 (ORCPT + 99 others); Mon, 13 Apr 2020 07:38:26 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2364 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729067AbgDMLiZ (ORCPT ); Mon, 13 Apr 2020 07:38:25 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E19F47D06B80F64DFC2E; Mon, 13 Apr 2020 19:38:22 +0800 (CST) Received: from huawei.com (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 13 Apr 2020 19:38:13 +0800 From: Li Bin To: , , CC: , , , Subject: [PATCH] scsi: sg: fix memory leak in sg_build_indirect Date: Mon, 13 Apr 2020 19:32:32 +0800 Message-ID: <1586777552-17524-1-git-send-email-huawei.libin@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a memory leak when there have failed, that we should free the pages under the condition rem_sz > 0. Signed-off-by: Li Bin --- drivers/scsi/sg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 4e6af592..8441ac5 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1959,8 +1959,12 @@ static long sg_compat_ioctl(struct file *filp, unsigned int cmd_in, unsigned lon k, rem_sz)); schp->bufflen = blk_size; - if (rem_sz > 0) /* must have failed */ + if (rem_sz > 0) { /* must have failed */ + for (i = 0; i < k; i++) + __free_pages(schp->pages[i], order); + return -ENOMEM; + } return 0; out: for (i = 0; i < k; i++) -- 1.7.12.4