Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4073426ybb; Mon, 13 Apr 2020 23:17:23 -0700 (PDT) X-Google-Smtp-Source: APiQypL7Crckcu4sS8laQnMDCoXRToOv7TVcwg6iexLjDokxrxZoL+iPTWfd6xDBjrlpR+yfV5MM X-Received: by 2002:a05:6402:2d1:: with SMTP id b17mr4176670edx.179.1586845043068; Mon, 13 Apr 2020 23:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586845043; cv=none; d=google.com; s=arc-20160816; b=bfZTxb0Vf7NLR7BGi9iWFRCOkHQX1eP4xA+H5si6jXFZOm28V5cvcj+7kK/JXk/q5a SB92HaYwbEQkfzfm/kqrX0Vs6bJt48aUw8Bh5MLa7TBoRQ+OZ9l5QaKDkdqsd6xG0k3N NMCmAfoOBr7FkOI4nF4hWUiZjnQgrRFKaJO5K2SxhBhkC18x39edOKaaYmndwSLmLEzr XXzlI9UCq17gll/WJkq2xu/Uw4xHGaHtSLa4CpvAnk/ubef3kt4ddxX4esEh1h8ksnsC 4emjkHzdnwwsKtZxn/8Wgd0Li/CJ9gdO7XI2E/2t/kA4D0G28XZGjEzS3BoyIO0aw9ie wXjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=y8hnAgVNha5A7aDTAKMXBUEo4tqaYF1BK1NumJKY+zo=; b=tCzG1RBU2DbjAnwPuC3F7qdQZk+WaxNQwEpoDAubnawOQbt5LiVcwZG00bDnabPYEJ btT5fi2a4NqPcsqP9BCPk0y+t4iw5/FXZl3JpkLPZFBXhRLP0ZfnqefOH6yI4SauAXGC e40cAgW4Yo293FiVvdV6BRAzy9DqIb/SFf5albrj2fAYqEsUHgEUKWRTsWH4gMuHe+qD nbPP2+5rnZPnoE+RSNkL7t+bhelcYywkbeHXqOubMHdQHL6qoSisswcpM4YwXgQML1pK 14h1ui9FaGS8GmDTVeG8ALsOxHq9s8tLGd1u3hOlfjkPaFip0Qw9wMpdN8E/0b3Kdn7G jfYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp22si4277566ejc.376.2020.04.13.23.16.59; Mon, 13 Apr 2020 23:17:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729272AbgDMLzF (ORCPT + 99 others); Mon, 13 Apr 2020 07:55:05 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:40736 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727907AbgDMLzE (ORCPT ); Mon, 13 Apr 2020 07:55:04 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.5]) by rmmx-syy-dmz-app03-12003 (RichMail) with SMTP id 2ee35e94530be9e-3a131; Mon, 13 Apr 2020 19:54:51 +0800 (CST) X-RM-TRANSID: 2ee35e94530be9e-3a131 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from [172.20.21.224] (unknown[112.25.154.146]) by rmsmtp-syy-appsvr03-12003 (RichMail) with SMTP id 2ee35e94530b271-c5fbd; Mon, 13 Apr 2020 19:54:51 +0800 (CST) X-RM-TRANSID: 2ee35e94530b271-c5fbd Subject: Re: [PATCH v3]ipmi:bt-bmc:Avoid unnecessary judgement To: minyard@acm.org Cc: arnd@arndb.de, gregkh@linuxfoundation.org, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20200408115958.2848-1-tangbin@cmss.chinamobile.com> <20200413113225.GB3587@minyard.net> From: Tang Bin Message-ID: <47c06465-9ae5-42c2-ca00-5c666521bbde@cmss.chinamobile.com> Date: Mon, 13 Apr 2020 19:56:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200413113225.GB3587@minyard.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Corey: On 2020/4/13 19:32, Corey Minyard wrote: > On Wed, Apr 08, 2020 at 07:59:58PM +0800, Tang Bin wrote: >> bt_bmc_probe() is only called with an openfirmware platform device. >> Therefore there is no need to check that the passed in device is NULL or >> that it has an openfirmware node. > I waited until after the merge window closed, this is queued for 5.8. Can I consider that the patch will be applied in 5.8? > I > changed the title to be "Avoid unnecessary check". You have modified it, which means I don't need to submit a new patch? > "Judgement", > although technically correct, has a legal or moral connotation. I'm sorry, I won't use that word again. Thanks for your instruction. Tang Bin >