Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4385394ybb; Tue, 14 Apr 2020 06:20:50 -0700 (PDT) X-Google-Smtp-Source: APiQypKpm7ardMDmxVCI+oDeo4QabpdkG5VeIvNP85uXkQM7iBW0E/WrVAFBqTnwfAbk13tVl+cX X-Received: by 2002:a05:6402:6d7:: with SMTP id n23mr19505944edy.21.1586870450378; Tue, 14 Apr 2020 06:20:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586870450; cv=none; d=google.com; s=arc-20160816; b=psye3sbklMy1wBPmI8FZrKCO8Rlkeq0Q9jP6mWoN+eXZu5sVOow6Ug2abg7HVwvBp3 fdMxglKzn8eAkSOuFe9yEftRu0FSwVhBkbFQn3RbONwttHisEhkgwr14NPf6UHxrha1a 1SRsf0qiXPqmIf0p5WBNWjEWYdcMjhe/gaJvcgyOleN/1ILAxKvMWwJNjjq10IeCm0Ne 88BAZ+tPlxVIuyO9GW2q3dDPDcMsJ7gGA7b61sgFAbOSN+JT0YeBAEH9TB55oEK+/Plz TvWZ6pQ+sCZ8RtM6DDHr6jwx2sb7Ldwyv0Syvz62M05e9hCrUkPN1jZLaowU9WEuHx7C p+tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1017ZZJ3wc9MMOodV5/kY0Bwih4ZV9N4oE4MH5gbFYs=; b=rhOTeiP640zzD3qYv4t2ZQzD4vQGeiU32bTBtl4GNL/3ioGtC32kpPSwpD5ubzMFmp xI/jQ7kGN1xdnoH3Y/CxPrCYnEIk/OY8KHZEqvqudKpuKgzvUvVGlzQkUNOvJBUR6dmy yvo9V8+QpqqnKqiZ7/8ZyIv+s8M+jdCkY7yOiD/Y/2uIAAMmzupOyBwKpTU+G1BQsnkA jgsfIMff1UB5SLpmRY5G0lxHS3TX5fj7NI1lAdKqJ8YwCxYV867yPkjA//8Iu3YChI98 6Ss8EMrXzWmWkOmYB+9DVuAm+6ppZthCAfuU4AtslRiF/gYx77tUyeMgv9VJWA4LBvMX pFJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R0+4nAcR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si7151713edn.452.2020.04.14.06.20.18; Tue, 14 Apr 2020 06:20:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=R0+4nAcR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731330AbgDMQM6 (ORCPT + 99 others); Mon, 13 Apr 2020 12:12:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:40222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731261AbgDMQM4 (ORCPT ); Mon, 13 Apr 2020 12:12:56 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C22EA2063A; Mon, 13 Apr 2020 16:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586794375; bh=PiJCskkBH4HQmJKrq6l2BUxAKLvdz6RRfLLB9w3jJOM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R0+4nAcRn19VFnyDoemwSPHdWrk2+ibRP2cCMe54Ax+eEkaLOH/HHthNQdQxqFWlI BAb45HSy3I0sObAAk4VaxQVGh4R1oi7KiL93fGwWboPEoSi0u5TbGzhxRpLn+1hqCF nvGmpWTb4eC43ldhTNkcfJIGviC5qh1UWrHtbkeo= Date: Mon, 13 Apr 2020 17:12:51 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , Subject: Re: [PATCH v3 1/2] iio: adc: ad7192: fix null pointer de-reference crash during probe Message-ID: <20200413171251.5407db5b@archlinux> In-Reply-To: <20200413082044.81101-1-alexandru.ardelean@analog.com> References: <20200413082044.81101-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Apr 2020 11:20:43 +0300 Alexandru Ardelean wrote: > When the 'spi_device_id' table was removed, it omitted to cleanup/fix the > assignment: > 'indio_dev->name = spi_get_device_id(spi)->name;' > > After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes > during probe with null de-ref. > > This change fixes this by introducing an ad7192_chip_info struct, and > defines all part-names [that should be assigned to indio_dev->name] in a > 'ad7192_chip_info_tbl' table. > > With this change, the old 'st->devid' is also moved to be a > 'chip_info->chip_id'. And the old 'ID_AD719X' macros have been renamed to > 'CHIPID_AD719X'. Tld identifiers have been re-purposed to be enum/index > values in the new 'ad7192_chip_info_tbl'. > > This should fix the bug, and maintain the ABI for the 'indio_dev->name' > field. > > Fixes: 66614ab2be38 ("staging: iio: adc: ad7192: removed spi_device_id") > Signed-off-by: Alexandru Ardelean Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > > Changelog v2 -> v3: > * reworked patch to introduce a chip_info struct for the part-name > * added 2nd patch to move of-table closer to the end of the file; this > patch is more cosmetic; has no fixes tag, but is on top of the previous > > Changelog v1 -> v2: > * fix colon for Fixes tag > * updated commit title a bit; to make it longer > > drivers/iio/adc/ad7192.c | 61 ++++++++++++++++++++++++++++++---------- > 1 file changed, 46 insertions(+), 15 deletions(-) > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > index 8ec28aa8fa8a..7e8662c5cb0e 100644 > --- a/drivers/iio/adc/ad7192.c > +++ b/drivers/iio/adc/ad7192.c > @@ -125,10 +125,10 @@ > #define AD7193_CH_AINCOM 0x600 /* AINCOM - AINCOM */ > > /* ID Register Bit Designations (AD7192_REG_ID) */ > -#define ID_AD7190 0x4 > -#define ID_AD7192 0x0 > -#define ID_AD7193 0x2 > -#define ID_AD7195 0x6 > +#define CHIPID_AD7190 0x4 > +#define CHIPID_AD7192 0x0 > +#define CHIPID_AD7193 0x2 > +#define CHIPID_AD7195 0x6 > #define AD7192_ID_MASK 0x0F > > /* GPOCON Register Bit Designations (AD7192_REG_GPOCON) */ > @@ -161,7 +161,20 @@ enum { > AD7192_SYSCALIB_FULL_SCALE, > }; > > +enum { > + ID_AD7190, > + ID_AD7192, > + ID_AD7193, > + ID_AD7195, > +}; > + > +struct ad7192_chip_info { > + unsigned int chip_id; > + const char *name; > +}; > + > struct ad7192_state { > + const struct ad7192_chip_info *chip_info; > struct regulator *avdd; > struct regulator *dvdd; > struct clk *mclk; > @@ -172,7 +185,6 @@ struct ad7192_state { > u32 conf; > u32 scale_avail[8][2]; > u8 gpocon; > - u8 devid; > u8 clock_sel; > struct mutex lock; /* protect sensor state */ > u8 syscalib_mode[8]; > @@ -348,7 +360,7 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np) > > id &= AD7192_ID_MASK; > > - if (id != st->devid) > + if (id != st->chip_info->chip_id) > dev_warn(&st->sd.spi->dev, "device ID query failed (0x%X)\n", > id); > > @@ -363,7 +375,7 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np) > st->mode |= AD7192_MODE_REJ60; > > refin2_en = of_property_read_bool(np, "adi,refin2-pins-enable"); > - if (refin2_en && st->devid != ID_AD7195) > + if (refin2_en && st->chip_info->chip_id != CHIPID_AD7195) > st->conf |= AD7192_CONF_REFSEL; > > st->conf &= ~AD7192_CONF_CHOP; > @@ -859,11 +871,30 @@ static const struct iio_chan_spec ad7193_channels[] = { > IIO_CHAN_SOFT_TIMESTAMP(14), > }; > > +static const struct ad7192_chip_info ad7192_chip_info_tbl[] = { > + [ID_AD7190] = { > + .chip_id = CHIPID_AD7190, > + .name = "ad7190", > + }, > + [ID_AD7192] = { > + .chip_id = CHIPID_AD7192, > + .name = "ad7192", > + }, > + [ID_AD7193] = { > + .chip_id = CHIPID_AD7193, > + .name = "ad7193", > + }, > + [ID_AD7195] = { > + .chip_id = CHIPID_AD7195, > + .name = "ad7195", > + }, > +}; > + > static int ad7192_channels_config(struct iio_dev *indio_dev) > { > struct ad7192_state *st = iio_priv(indio_dev); > > - switch (st->devid) { > + switch (st->chip_info->chip_id) { > case ID_AD7193: > indio_dev->channels = ad7193_channels; > indio_dev->num_channels = ARRAY_SIZE(ad7193_channels); > @@ -878,10 +909,10 @@ static int ad7192_channels_config(struct iio_dev *indio_dev) > } > > static const struct of_device_id ad7192_of_match[] = { > - { .compatible = "adi,ad7190", .data = (void *)ID_AD7190 }, > - { .compatible = "adi,ad7192", .data = (void *)ID_AD7192 }, > - { .compatible = "adi,ad7193", .data = (void *)ID_AD7193 }, > - { .compatible = "adi,ad7195", .data = (void *)ID_AD7195 }, > + { .compatible = "adi,ad7190", .data = &ad7192_chip_info_tbl[ID_AD7190] }, > + { .compatible = "adi,ad7192", .data = &ad7192_chip_info_tbl[ID_AD7192] }, > + { .compatible = "adi,ad7193", .data = &ad7192_chip_info_tbl[ID_AD7193] }, > + { .compatible = "adi,ad7195", .data = &ad7192_chip_info_tbl[ID_AD7195] }, > {} > }; > MODULE_DEVICE_TABLE(of, ad7192_of_match); > @@ -938,16 +969,16 @@ static int ad7192_probe(struct spi_device *spi) > } > > spi_set_drvdata(spi, indio_dev); > - st->devid = (unsigned long)of_device_get_match_data(&spi->dev); > + st->chip_info = of_device_get_match_data(&spi->dev); > indio_dev->dev.parent = &spi->dev; > - indio_dev->name = spi_get_device_id(spi)->name; > + indio_dev->name = st->chip_info->name; > indio_dev->modes = INDIO_DIRECT_MODE; > > ret = ad7192_channels_config(indio_dev); > if (ret < 0) > goto error_disable_dvdd; > > - if (st->devid == ID_AD7195) > + if (st->chip_info->chip_id == CHIPID_AD7195) > indio_dev->info = &ad7195_info; > else > indio_dev->info = &ad7192_info;