Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4390810ybb; Tue, 14 Apr 2020 06:26:49 -0700 (PDT) X-Google-Smtp-Source: APiQypLO0+avXlUGMmtaw3bKhYLUX97ax5QsVCrklCVaPFHaKvGb/8uDnY0jiQhlhFruDCsOH32e X-Received: by 2002:a17:906:855a:: with SMTP id h26mr135811ejy.56.1586870809713; Tue, 14 Apr 2020 06:26:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586870809; cv=none; d=google.com; s=arc-20160816; b=mzU/DnjpXRjALcqFRR/a43u8nocz2/I2KKotk7x3fVjc44MWtyXLbQZwKZUhVRQ4qP y+SRJme2nTo9CYYRulbLMxC2UlIaYBiqslIlsCd0qcorZlQxwTuHal4BeRRapLbsrvWv ttt1WJ74HiRguynKNCR5hVaPNwuygCrwiYsDJ9Yz3tQhkhYExwq4+b4XYUVl/v6Ymhsj /IWVBwNInQ/2SNf9bQj18XXOEljNUVb4Lhfqniz2dNKKfNj/4Ncm4UjsT2RXE9if10Zs WRGJ1ITPjnYbDfIte5nDJvpHtxd7ixt9d55cNXeKdcpBNuVqsoD1bHFYHHstRom2PKNI 5hKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UAfRx68GmugaLtPZinUg/SwF6hel61cQgW6F9C717Cw=; b=y8Cl6JvnK8BlGBBCFOX5LBEMoHykFYJW6PdhhShKpve0xU78IjwOURGzm+WR9/c2mj PudbNQcNtAccOBiye0AFcNqoEzfmpP5sJ0pCyAfHQkhLyIJ04qWD/fqubDBrl39jh+Bu Zh8m4KHQI0V2X8CJfaJ+yZmQs6ZB21OgPZkltqI9skMZyOinv4A99kliluAsr2BU4UfR mvsp4yzqEVUvatQE9vowvObZD8QwY6MfRDmE+fpibjWTnQSZV8iSXOiV9bgW0HRD98UM gHzTWhl7OZRC4Qt+YTnxTIyS8cwze9r2/UKyOJQIhtVyPsCbsAOYLwexkbC7lCxqnVjH /ecQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VMQYWJ1Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e14si8521543edk.310.2020.04.14.06.26.25; Tue, 14 Apr 2020 06:26:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=VMQYWJ1Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732510AbgDMRGf (ORCPT + 99 others); Mon, 13 Apr 2020 13:06:35 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:37628 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732482AbgDMRGb (ORCPT ); Mon, 13 Apr 2020 13:06:31 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03DH5e1j186408; Mon, 13 Apr 2020 17:06:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=UAfRx68GmugaLtPZinUg/SwF6hel61cQgW6F9C717Cw=; b=VMQYWJ1YGtI4OmsNMa5Z3PjHN1LLlly2qYJbeEGxJfSs0RlbHWZTZ9TqwVy2dkl9gSDL h5234uiAA/9y741PT2sNDTczXE1sChiF/8X1HiuUipo4jqJFcaSexs3EVmygV34e89X8 k8djMEXXdlM+ZfSiXmQX5xIkU1UV5FAuZGuMhtWVeGs4juml8lBdQILVdiL33AAWVWGW vBdlq6TMo1epDvd42rHezyZU+FSLImicPR3nDPsqz+CAlqFDZ9EXoiIgxbY1JP4ckY44 Rz4RsTB+j5xk31gjIuasJRLS6rYRUmIxMysC0RyJe4wAHATKE65nuqfzfQCtVPbLBchT Cg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 30b6hpfq2s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Apr 2020 17:06:05 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03DH1uQ0105916; Mon, 13 Apr 2020 17:06:05 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 30bqpck88c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Apr 2020 17:06:04 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03DH5wCw006578; Mon, 13 Apr 2020 17:06:01 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Apr 2020 10:05:58 -0700 Date: Mon, 13 Apr 2020 13:06:18 -0400 From: Daniel Jordan To: Michel Lespinasse Cc: Andrew Morton , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Markus Elfring Subject: Re: [PATCH v3 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Message-ID: <20200413170618.3luttzyzwjsd5y26@ca-dmjordan1.us.oracle.com> References: <20200327225102.25061-1-walken@google.com> <20200327225102.25061-6-walken@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327225102.25061-6-walken@google.com> User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004130131 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004130131 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2020 at 03:50:57PM -0700, Michel Lespinasse wrote: > Convert the last few remaining mmap_sem rwsem calls to use the new > mmap locking API. These were missed by coccinelle for some reason > (I think coccinelle does not support some of the preprocessor > constructs in these files ?) Adding the wrappers for instrumentation makes sense to me. For patches 1-5, you can add Reviewed-by: Daniel Jordan I'll wait for the next version to review the rest.