Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 4/6] power: supply: Add support for mps mp2629 battery
 charger
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        Sebastian Reichel <sre@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
References: <20200413173656.28522-1-sravanhome@gmail.com>
 <20200413173656.28522-5-sravanhome@gmail.com>
 <CAHp75VeYFY1CW4AH+D4HAgzppMZ5J8dL8kKPYmcwsXNVGNSYjQ@mail.gmail.com>
From:   saravanan sekar <sravanhome@gmail.com>
Message-ID: <6cfab0a6-c3eb-bd9b-6572-b49e3205524f@gmail.com>
Date:   Mon, 13 Apr 2020 22:28:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <CAHp75VeYFY1CW4AH+D4HAgzppMZ5J8dL8kKPYmcwsXNVGNSYjQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy,

On 13/04/20 10:10 pm, Andy Shevchenko wrote:
> On Mon, Apr 13, 2020 at 8:37 PM Saravanan Sekar <sravanhome@gmail.com> wrote:
>> The mp2629 provides switching-mode battery charge management for
>> single-cell Li-ion or Li-polymer battery. Driver supports the
>> access/control input source and battery charging parameters.
> ...
>
>> +static int mp2629_charger_probe(struct platform_device *pdev)
>> +{
>> +       irq = platform_get_irq(to_platform_device(pdev->dev.parent), 0);
> Why not to use temporary variable dev?
>
> This should be platform_get_irq_optional().


Platform_get_irq in turn calls platform_get_irq_optional. It was 
suggested by Lee and is it mandatory to change it?

>> +       if (irq) {
>> +               ret = devm_request_irq(dev, irq, mp2629_irq_handler,
>> +                                IRQF_TRIGGER_RISING, "mp2629-charger",
>> +                                charger);
>> +               if (ret) {
>> +                       dev_err(dev, "failed to request gpio IRQ\n");
>> +                       goto iio_fail;
>> +               }
>> +       }
>> +}