Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1586468669-21456-1-git-send-email-victor.erminpour@oracle.com>
 <CAMj1kXGgYYx=9rq-Ficw3vS6FX_0nb-hRStXijh7H4zdD=+Gaw@mail.gmail.com>
 <aee6c7cc-24c7-2822-47d5-1e05413a8024@oracle.com> <CAMj1kXFF3gR+LyE1VbLuwnRA3CzQtF90mv7rpw9x2RcyugO1JA@mail.gmail.com>
 <95f421ad-6ba7-b968-d605-c464bc1df4e2@oracle.com>
In-Reply-To: <95f421ad-6ba7-b968-d605-c464bc1df4e2@oracle.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 14 Apr 2020 08:46:01 +0200
Message-ID: <CAMj1kXEg5YmoRg9e0T1PV43v8Fm6+88czV+bp=6XToK7PJ_qwg@mail.gmail.com>
Subject: Re: [PATCH] efi/libstub/arm64: Enable __efistub_global define in
 .data section
To:     Victor Erminpour <victor.erminpour@oracle.com>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 14 Apr 2020 at 00:57, Victor Erminpour
<victor.erminpour@oracle.com> wrote:
>
>
>
> On 4/10/20 11:39 PM, Ard Biesheuvel wrote:
> > On Sat, 11 Apr 2020 at 00:12, Victor Erminpour
> > <victor.erminpour@oracle.com> wrote:
> >>
> >>
> >>
> >> On 4/10/20 1:09 AM, Ard Biesheuvel wrote:
> >>> On Thu, 9 Apr 2020 at 23:44, Victor Erminpour
> >>> <victor.erminpour@oracle.com> wrote:
> >>>>
> >>>> Enable the __efistub_global define to place variables in the
> >>>> .data section for both CONFIG_ARM and CONFIG_ARM64.
> >>>>
> >>>> This places the EFIstub sys_table variable and other EFIstub
> >>>> static variables in the .data section for both CONFIG_ARM and
> >>>> CONFIG_ARM64.
> >>>>
> >>>
> >>> What does that achieve?
> >>
> >> Hi Ard,
> >>
> >> Without placing these global variables in .data, I get the
> >> following errors when booting an ARM64 EFI system:
> >>
> >> EFI stub: ERROR: Exit boot services failed.
> >> EFI stub: ERROR: Failed to update FDT and exit boot services
> >>
> >
> > Which boot loader are you using? Does this involve shim?
> >
>
> grub2-efi-aa64-2.02-0.80.0.4.el7.aarch64
> shim-aa64-15-1.0.4.el7.aarch64
>

Does your system give access to the UEFI shell? If so, could you
please try booting the [uncompressed] Image file from the command
prompt? Which hardware are you booting?

> > Also, does it help if you add 'efi=no_disable_early_pci_dma'?
> >
>
> Tried this boot time option, but to no effect.
>
> >
> >>
> >> I know that the ARM64 linker script is supposed to put the
> >> .init.bss into the .init.data section, but I don't think this
> >> is happening for all systems.
> >>
> >> Having it explicitly enabled for CONFIG_ARM64 worked for me.
> >>
> >
> > OK, thanks for the report. However, we will be removing
> > __efistub_global entirely during the next cycle, so this is not the
> > right fix.
>
> Thanks Ard, this sounds promising!
>

Quite the opposite, unfortunately. It means the feature you are using
to fix your boot issue is going away.

This really looks like a bootloader issue to me, so let's narrow this
down first. If there is a real kernel issue here that needs
__efistub_global to be fixed, we obviously won't be removing it.