Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4474477ybb; Tue, 14 Apr 2020 08:02:20 -0700 (PDT) X-Google-Smtp-Source: APiQypKkvvwz7SJQVxPXRp5GJm6etr7UaCakO2XHv6CofwtEcQCdrMx0dUe3hvQzrGo8NnAUy4fY X-Received: by 2002:a50:9f6b:: with SMTP id b98mr7262476edf.119.1586876540080; Tue, 14 Apr 2020 08:02:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586876540; cv=none; d=google.com; s=arc-20160816; b=h8uOWPalYs9KM9EwtrzRy0cOzE8BgVyAe7y/N8Ebr6ERYAt6A0wNGTQVxJ4TCdAAkO 8S7xNLqSqIHxxXwN3o4hjbyvdFxJziIKolt2oTeu9CpsAJWa0ajcJS+Y730OJGqYM4pr kPikG9rExAJ72URG4PT7kQx9v2MeOQM1KmWIdut8r2hmpR9TIehcQ1eRoKkJuZP4AWo0 iSQo0KkK2/g5sAiCfOpWIixwlrY6c165jzYAOpzC4qiEbWeXF8ng/JpM7GejhazAeAc2 bH2BUH4JB22qHQqwz/JMb89xkCqgyl6chWmT8X95IjnZ0aOGNClmDhXeOJjCHyCQoLbo FFWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Of87X/gGHd7WK7J8InDBiy0jDOtLSnaghXrcb3fjgfk=; b=RIk6wXvRLJH7i0WSCJ5Ky4P1SGDc6dcgXcHLOgbqPQIpyFSJeLXA5CNggm48T51FHS mP7NS0Oyl/LZsD27LWk46D2adXrHerbmh8C7ZPLLABXKZSOhUm5c8P1T2Gr8b8YnC1R9 oRuKY/OYlitEKBScduw6P8GBB0/9szISqF4nxX9C9pWtb3ybDUEN1/eNPKhL13M8AzO3 HjSSoV+rShKEccFQ012tJ00XkiDdYBOC0d/Vghl1vpdwrirk74f3I6EKraKunvkLaZoG zVWO2dEjVdgcuUuzwFVvA//Gy9tA3GH/I2wz8GGuJZDYn4rtMT0f21j4wHLKIua3PCo1 apKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qi+aAYqV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y5si10338624edm.492.2020.04.14.08.01.53; Tue, 14 Apr 2020 08:02:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Qi+aAYqV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406977AbgDNIIa (ORCPT + 99 others); Tue, 14 Apr 2020 04:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2406964AbgDNIIM (ORCPT ); Tue, 14 Apr 2020 04:08:12 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57351C0A3BDC for ; Tue, 14 Apr 2020 01:08:07 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k11so12590292wrp.5 for ; Tue, 14 Apr 2020 01:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Of87X/gGHd7WK7J8InDBiy0jDOtLSnaghXrcb3fjgfk=; b=Qi+aAYqVu1eN15qmGiNzA8fNa4lIaXjb7w8Ocp8Gc0hvk+JIaKlkVXzyxUG8n0kj+r UO5wQRuYWMusYRen73PY8mnpxj7c2gEagVixnKH7uYpOo25BzIAhsiy4AwByxwVKgDTX 3usXFCaxp+gOky+4ixr3sYj7SJeR2HTcyBG8WdE5NSYpwB+WADiE6Jvju2AScK2TrryU m0Nbcv9ajXflZubAOOw8jM1w57tWTxiDu8rNj7uzuriDtcDYZAa3eT9hU0TcjfE4Hm8v K5mfMgvUSBew+h/w06khwgn9kCDZAA34fzfhg7vHcnzLGX4BOXe2yx/so+jE4QPF1o8e YT5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Of87X/gGHd7WK7J8InDBiy0jDOtLSnaghXrcb3fjgfk=; b=pLbUjqbUO8k/GbdbwSwHx02GVxit1hdc0i8RWmpRrx/wIxNqzcML/+Hvgu2fDhxIdn J0Zz02yAtSa4qXr2xvOk203WK/HvLv/nSEUKhH1lczfCtCw7bbpxgFDVU/Q44bYcVIKC 8cmrr5d8uuAK9no8MssAkA77tR+9vu1Ij8VPuKXjKLXv4llzkTaXe8agIc3OE2NpmMyG N7IZy4paHyu/bfZgDDEU7vuhDaxbc0FWwMQ2hepYf4BtBEi53rJ0pRQlcF0D5ThYF83T KPpmXeZRTAOrd6Q/P6qsfPKkMA7w2zO9+5bFmDWHU8THH4uCGiyVtsGlHmttdk7/XEfu Emkw== X-Gm-Message-State: AGi0PuZ26fggaeWh5rCpaqRrowjMFIx0NKlz1ARJiKU+qAoegoHtvAQf lqKI9h57Xqx3GuHBTZ1PtRmC5A== X-Received: by 2002:a5d:4286:: with SMTP id k6mr10371255wrq.222.1586851685895; Tue, 14 Apr 2020 01:08:05 -0700 (PDT) Received: from dell ([95.149.164.124]) by smtp.gmail.com with ESMTPSA id f63sm17383374wma.47.2020.04.14.01.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 01:08:05 -0700 (PDT) Date: Tue, 14 Apr 2020 09:09:05 +0100 From: Lee Jones To: Tim Harvey Cc: Linux HWMON List , Robert Jones , Rob Herring , Frank Rowand , Device Tree Mailing List , open list , Jean Delvare , Guenter Roeck Subject: Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver Message-ID: <20200414080905.GC2167633@dell> References: <1585341214-25285-1-git-send-email-tharvey@gateworks.com> <1585341214-25285-3-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Apr 2020, Tim Harvey wrote: > On Fri, Mar 27, 2020 at 1:33 PM Tim Harvey wrote: > > > > The Gateworks System Controller (GSC) is an I2C slave controller > > implemented with an MSP430 micro-controller whose firmware embeds the > > following features: > > - I/O expander (16 GPIO's) using PCA955x protocol > > - Real Time Clock using DS1672 protocol > > - User EEPROM using AT24 protocol > > - HWMON using custom protocol > > - Interrupt controller with tamper detect, user pushbotton > > - Watchdog controller capable of full board power-cycle > > - Power Control capable of full board power-cycle > > > > see http://trac.gateworks.com/wiki/gsc for more details > > > > Cc: Randy Dunlap > > Signed-off-by: Tim Harvey > > --- > > MAINTAINERS | 8 ++ > > drivers/mfd/Kconfig | 10 ++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/gateworks-gsc.c | 288 ++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/mfd/gsc.h | 73 +++++++++++ > > 5 files changed, 380 insertions(+) > > create mode 100644 drivers/mfd/gateworks-gsc.c > > create mode 100644 include/linux/mfd/gsc.h [...] Please clip your responses. > Lee, > > Do you have time to look at this? Rob has reviewed the dt-bindings and > Guenter has reviewed the hwmon driver so this is the only patch > remaining in the series that needs review/sign-off. It's on the list. Please bear in mind that the merge-window has been open for the past 2 weeks. Usually reviewing cadence slows down during this period. It should be ramping up again this week. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog