Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1586779281-103078-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1586779281-103078-1-git-send-email-zou_wei@huawei.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 14 Apr 2020 10:08:58 +0200
Message-ID: <CAKfTPtDtJo2Vnziy9cLGyORqmN-1u+Mf=jKZmeKR0yMuHz1kuA@mail.gmail.com>
Subject: Re: [PATCH-next] sched/topology: use true, false for bool variable
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 13 Apr 2020 at 13:55, Zou Wei <zou_wei@huawei.com> wrote:
>
> Fixes coccicheck warning:
>
> kernel/sched/topology.c:224:3-22: WARNING: Assignment of 0/1 to bool variable
> kernel/sched/topology.c:226:3-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

You will probably be interested by this thread
https://lkml.org/lkml/2020/3/27/785

> ---
>  kernel/sched/topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8344757b..e4d6464 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -221,9 +221,9 @@ int sched_energy_aware_handler(struct ctl_table *table, int write,
>                 state = static_branch_unlikely(&sched_energy_present);
>                 if (state != sysctl_sched_energy_aware) {
>                         mutex_lock(&sched_energy_mutex);
> -                       sched_energy_update = 1;
> +                       sched_energy_update = true;
>                         rebuild_sched_domains();
> -                       sched_energy_update = 0;
> +                       sched_energy_update = false;
>                         mutex_unlock(&sched_energy_mutex);
>                 }
>         }
> --
> 2.6.2
>