Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200408175058.2.I1f56fe698017f22d6e825c913c256d5afc2ad69f@changeid>
 <CAHp75VcuPoVK_+KV+88Di1dUFZ9S8-1nNqo2s8a_n3vgSMoecg@mail.gmail.com> <CAHcu+VZMiFVt9L9kNCTtsmxUP-7tO+pBpCOtMHQPotuye_2w1A@mail.gmail.com>
In-Reply-To: <CAHcu+VZMiFVt9L9kNCTtsmxUP-7tO+pBpCOtMHQPotuye_2w1A@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 14 Apr 2020 12:10:56 +0300
Message-ID: <CAHp75VemvD0mvDHWorSFhqOKaQ1Y_vLYVAQmnb8iz30AH431+Q@mail.gmail.com>
Subject: Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver
To:     Daniel Campello <campello@google.com>
Cc:     LKML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Enrico Granata <egranata@chromium.org>,
        Andreas Klinger <ak@it-klinger.de>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-iio <linux-iio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 14, 2020 at 1:56 AM Daniel Campello <campello@google.com> wrote:
> On Fri, Apr 10, 2020 at 4:52 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Thu, Apr 9, 2020 at 2:54 AM Daniel Campello <campello@chromium.org> wrote:

As far I understand you agreed on the rest.
Correct?

...

> > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> > > Signed-off-by: Enrico Granata <egranata@chromium.org>
> >
> > This is not understandable. Are they who helped you develop the code
> > (we have a special tag, i.e. Co-developed-by in addition to SoB), or
> > just people in the middle? Then the question is, how come author is
> > you and not Gwendal?
> >
> This patch was initially developed by Gwendal and Enrico (here:
> crrev.com/c/1089826).

So, tags should include
 SoB: Gwendal ...
 Co-developed-by: Enrico ...
 SoB: Enrico ...
 Co-developed-by: yours (if you developed it)
 SoB: yours

and on top git commit --amend --author="Gwendal  ..."

...

> > > +#define SX9310_REG_IRQ_MSK                             0x03
> >
> > Is MSK abbreviation in datasheet? Please spell it how it's in datasheet.
> Yes, they indead use MSK.

Okay!


-- 
With Best Regards,
Andy Shevchenko