Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <66c3db9b1978a384246c729034a934cc558b75a6.camel@redhat.com>
Subject: Re: WARNING in hwsim_new_radio_nl
From:   Paolo Abeni <pabeni@redhat.com>
To:     syzbot <syzbot+a4aee3f42d7584d76761@syzkaller.appspotmail.com>,
        davem@davemloft.net, johannes@sipsolutions.net,
        kvalo@codeaurora.org, linux-kernel@vger.kernel.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Date:   Tue, 14 Apr 2020 12:42:17 +0200
In-Reply-To: <000000000000bb471d05a2f246d7@google.com>
References: <000000000000bb471d05a2f246d7@google.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

#syz test git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master

I don't see why the bisection pointed to the MPTCP commit ?!? the
following patch should address the issue.
---
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c
index 7fe8207db6ae..2082abdb08d4 100644
--- a/drivers/net/wireless/mac80211_hwsim.c
+++ b/drivers/net/wireless/mac80211_hwsim.c
@@ -635,7 +635,8 @@ static const struct nla_policy hwsim_genl_policy[HWSIM_ATTR_MAX + 1] = {
        [HWSIM_ATTR_SUPPORT_P2P_DEVICE] = { .type = NLA_FLAG },
        [HWSIM_ATTR_USE_CHANCTX] = { .type = NLA_FLAG },
        [HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE] = { .type = NLA_FLAG },
-       [HWSIM_ATTR_RADIO_NAME] = { .type = NLA_STRING },
+       [HWSIM_ATTR_RADIO_NAME] = { .type = NLA_STRING,
+                                   .len = NL80211_WIPHY_NAME_MAXLEN },
        [HWSIM_ATTR_NO_VIF] = { .type = NLA_FLAG },
        [HWSIM_ATTR_FREQ] = { .type = NLA_U32 },
        [HWSIM_ATTR_TX_INFO_FLAGS] = { .type = NLA_BINARY },