Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
Subject: Re: [PATCH] selftests/tpm2: Change exception handling to be Python 3
 compatible
From:   Ezra Buehler <ezra@easyb.ch>
In-Reply-To: <20200414073806.GE8403@linux.intel.com>
Date:   Tue, 14 Apr 2020 13:14:11 +0200
Cc:     Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
        linux-integrity@vger.kernel.org,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch>
References: <20200412143656.72955-1-jarkko.sakkinen@linux.intel.com>
 <1FE03B4F-C42C-4B5F-A4B5-8169705911FA@easyb.ch>
 <20200412170719.GA324408@linux.intel.com>
 <531D50E8-E8FC-402E-9226-6000E8B6E960@easyb.ch>
 <20200413180440.GA10917@linux.intel.com>
 <D670A3F7-6FE2-4A07-8251-680C2ED27764@easyb.ch>
 <20200414073806.GE8403@linux.intel.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14 Apr 2020, at 09:38, Jarkko Sakkinen =
<jarkko.sakkinen@linux.intel.com> wrote:
> OK, I'm aware about the dynamic nature but in this case it is somewhat
> counter intuitive since it is part of the exception clause. You'd =
except
> the Python interpreter to complain.

I agree.

> So, is Flake8 like the standard to be used?

Pretty much, yes. There is also Pylint though. Among other things, they
both check for PEP 8 (official) coding style compliance.

Cheers,
Ezra.

> On 14 Apr 2020, at 09:38, Jarkko Sakkinen =
<jarkko.sakkinen@linux.intel.com> wrote:
>=20
> On Tue, Apr 14, 2020 at 07:45:33AM +0200, Ezra Buehler wrote:
>> Hi Jarkko,
>>=20
>> On 13 Apr 2020, at 20:04, Jarkko Sakkinen =
<jarkko.sakkinen@linux.intel.com> wrote:
>>>=20
>>> On Mon, Apr 13, 2020 at 07:02:20AM +0200, Ezra Buehler wrote:
>>>> Hi Jarkko,
>>>>=20
>>>> On 12 Apr 2020, at 19:07, Jarkko Sakkinen =
<jarkko.sakkinen@linux.intel.com> wrote:
>>>>>=20
>>>>> On Sun, Apr 12, 2020 at 05:02:27PM +0200, Ezra Buehler wrote:
>>>>>> Hi Jarkkon,
>>>>>>=20
>>>>>>> On 12 Apr 2020, at 16:36, Jarkko Sakkinen =
<jarkko.sakkinen@linux.intel.com> wrote:
>>>>>>> +        except ProtocolError(e):
>>>>>>=20
>>>>>> Should this not be
>>>>>>=20
>>>>>>      except ProtocolError as e:
>>>>>=20
>>>>> Unless there is a functional difference, does it matter?
>>>>>=20
>>>>> /Jarkko
>>>>=20
>>>> Well, your patch confuses me a lot. It looks to me like you are =
passing
>>>> the undefined `e` variable to the constructor.
>>>>=20
>>>> When I run flake8 on it I get following error (among others):
>>>>=20
>>>>   F821 undefined name 'e'
>>>=20
>>> I don't know what flake8 is.
>>=20
>> https://flake8.pycqa.org/en/latest/
>>=20
>>>> What I suggested is the standard syntax:
>>>> https://docs.python.org/3/tutorial/errors.html
>>>=20
>>> It passed the Python 3 interpreter.
>>=20
>> That is because it is technically valid syntax.
>>=20
>>>> Did you test this? You should get an error as soon as an exception
>>>> occurs.
>>>=20
>>> Yes. Interpreter did not complain. I did not know that the language
>>> is broken that way that you have to exercise the code path to get
>>> a syntax error.
>>=20
>> That is due to the dynamic nature of Python. You won=E2=80=99t get a =
syntax
>> error. You will get an exception:
>>=20
>>    NameError: name 'e' is not defined
>>=20
>> Python has to assume that `e` might be defined at runtime. However,
>> style checkers will complain.
>=20
> OK, I'm aware about the dynamic nature but in this case it is somewhat
> counter intuitive since it is part of the exception clause. You'd =
except
> the Python interpreter to complain.
>=20
> So, is Flake8 like the standard to be used?
>=20
> /Jarkko