Message-ID: <440468DB.5060605@pobox.com>
Date: Tue, 28 Feb 2006 10:14:35 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
MIME-Version: 1.0
To: Hannes Reinecke <hare@suse.de>
CC: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Fixup ahci suspend / resume
References: <44045FB1.5040408@suse.de>
In-Reply-To: <44045FB1.5040408@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 32

Hannes Reinecke wrote:
> From: Hannes Reinecke <hare@suse.de>
> Subject: AHCI suspend / resume fixes.
> 
> The current ahci driver has the problem that it doesn't resume properly.
> Or rather, that resuming is unstable.
> Reason being is that AHCI has 4 registers containing the DMA address it
> should write things to. Of course there is no guarantee that Linux has
> assigned the same address to the DMA area across reboots.
> So we should better re-initialize those registers after resume.
> 
> The patch also improves the port_start / port_stop routines to be more
> closely modelled after the spec. This also avoids a nasty msleep(500)
> during initialisation.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>


Seems sane at first glance, but can you please regenerate this against 
libata-dev.git#upstream ?

Upstream 2.6.x doesn't care at all about suspend/resume, and AHCI has 
seen several modifications in #upstream that are waiting for 2.6.17.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/