Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4540060ybb; Tue, 14 Apr 2020 09:14:14 -0700 (PDT) X-Google-Smtp-Source: APiQypL32gReuhVKirnQx6/8amgR20OH5hu5+j0A5AGc9geQ+OP4I7hGyGOVItHv4+xF9K1wSN+5 X-Received: by 2002:a50:e8cc:: with SMTP id l12mr18907103edn.204.1586880854626; Tue, 14 Apr 2020 09:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586880854; cv=none; d=google.com; s=arc-20160816; b=DRH85Y6ppVPJdyOkIKUSyPW9vOz89bhxIMBvJ7WxAWYGkilZyiOxHdAUPcOFNpwWUY qDAHMJlyCQC/PVf1Wl9oFERdvW3s2FC+p/bSU8ZSW3yV8Jm9OdVj0PxcDVmDiY10DNYR /vXUADYKujFRhnlHhLO6DYzmEM+mRKS8cINfJ+yk4ejrkz0MCuS1XY4sb6JQQBAgcRee KTxng6qDzHnfRlp0Fo2djJvHGYUjk2UPFhfuZ1wTb8XvgRmN259bUz64RgqpYU1vechy A3jj+EK2lbsrbOO09aLd6twxnzYM7hBH4HYgCL5sUouaYxSYFwj0W+qeeY1NGNxavEHE bE1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WH0wZE6uzzA+a4e5P2qc0W40GDZZ9BneKHmXZLZLm18=; b=V4BNpzjojTF2omKL2rEeKZCo8szSQ0pNtcz1WEqFC17NCVptaN1/7RMrs1JQG2JaYS oLRUOhxbCzYt2Hru/xJhGFrqa6fL3uyCdGjNqFHPSjPSQIhv25Hv6e0tpsLuMuv2IFJR t5E4F/ozdKwT0bvpP6oUezBMcCdsUY0a3ejBM2rrnbckeyC7dNeHeA0hzXKf3tJex02e pfAvb/UdKP8kmY+UC5zhaRDW/D2JQTmJTfrxF7pKzCNhbhpzzKMVZ5IhRdPMC5O3uRpG brsx4+jYMSAMzZ3ygQSMktQcXz16XYQR0yzIPSTZujTd/iJqiUO6rjsr5MxsQX8uxZdz CCLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Gxpg4uqB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a26si2210227edx.154.2020.04.14.09.13.51; Tue, 14 Apr 2020 09:14:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Gxpg4uqB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390722AbgDNO1L (ORCPT + 99 others); Tue, 14 Apr 2020 10:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390695AbgDNO1A (ORCPT ); Tue, 14 Apr 2020 10:27:00 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 163CFC061A0C; Tue, 14 Apr 2020 07:27:00 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id z9so5268856pjd.2; Tue, 14 Apr 2020 07:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WH0wZE6uzzA+a4e5P2qc0W40GDZZ9BneKHmXZLZLm18=; b=Gxpg4uqB8pTwf64kuCO6WCL4wKc87NfZQkmnBDLVsXjiS4BRKT4lEK63M+qjksSIqS BnowqgotjG2fDVoYtOzVdywfwQJlMhyk0xrPOyWWxGI3VJUwOdR+fCSQabLY4wLKBVXv e0ObYzePX4rF67B5iCdGCRhrjzBrAMVj+bnzHZJVz3MqNMN0W0KCzkDbuVmIGtOfllYF 4zuK8LxPTtyME/gehxKOcrpZtP70YI553CWgOZOhd+TG6vqXmJpiXwU0/1Ws0KL9kX1+ s7R8xYS2e9bJJd8E3dKUzv8zCHCox3S530GQ7H6GPF4dVR65YQwI/ZridBtFTbKE2H+W 0X2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WH0wZE6uzzA+a4e5P2qc0W40GDZZ9BneKHmXZLZLm18=; b=twy0+0QR5Qk29oVwiuSN6kW0OSbZrc42FIBrBe2PvaGJkj7qBdV77G+s1uM1Z9TkzG GoBwk/0lAfUQMYUvzJDMSofbVNA9uYEDsmU35T3LM+ZIK0Q+6uptIQ1ncLiCU/yZyeZ/ vHLFteblj0ORHoQ0lxzdMeJ+uCrDZOlbzK8VsvKqBIDnNdQhLcqWFhSr3/Xmm/8ggaMW 8tyeagiCeKWqqITQ0JWA9KDh4JvXJO3Xxn8jFbDBX5lCFbb5j1U/Ve1SIoAYBsalOEQ3 nyhgFS0a8me97AGz2/JDCvgQ1M5sNcM8yk7UFN9B1CSYJ/9BlwWxWvqMN6f8vDcBfZQp /9Kg== X-Gm-Message-State: AGi0PuZCbpnrVZ5oVV2pPytPfTSYLe+fNptmnCQz6PN7SNTWFwd6tEN9 Kaazg/fl37RpopW+FzjRhmA= X-Received: by 2002:a17:90b:3648:: with SMTP id nh8mr357049pjb.153.1586874419453; Tue, 14 Apr 2020 07:26:59 -0700 (PDT) Received: from localhost ([89.208.244.140]) by smtp.gmail.com with ESMTPSA id d23sm11228901pfq.210.2020.04.14.07.26.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 07:26:59 -0700 (PDT) From: Dejin Zheng To: linus.walleij@linaro.org, patrice.chotard@st.com, info@metux.net, allison@lohutok.net, nehal-bakulchandra.shah@amd.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dejin Zheng Subject: [PATCH v1] i2c: img-scb: remove duplicate dev_err() Date: Tue, 14 Apr 2020 22:26:50 +0800 Message-Id: <20200414142650.29359-1-zhengdejin5@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org it will print an error message by itself when platform_get_irq() goes wrong. so don't need dev_err() in here again. Signed-off-by: Dejin Zheng --- drivers/i2c/busses/i2c-img-scb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c index 422097a31c95..2f6de763816a 100644 --- a/drivers/i2c/busses/i2c-img-scb.c +++ b/drivers/i2c/busses/i2c-img-scb.c @@ -1344,10 +1344,8 @@ static int img_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c->base); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "can't get irq number\n"); + if (irq < 0) return irq; - } i2c->sys_clk = devm_clk_get(&pdev->dev, "sys"); if (IS_ERR(i2c->sys_clk)) { -- 2.25.0