Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4557796ybb; Tue, 14 Apr 2020 09:34:33 -0700 (PDT) X-Google-Smtp-Source: APiQypKyl0iZq3EScbj/g6o3kSbZToP+2pjDFORS2E7T7ymChJsM3CFyCS6jH75I4lUzwXhq3wzA X-Received: by 2002:aa7:da0b:: with SMTP id r11mr21727099eds.63.1586882073851; Tue, 14 Apr 2020 09:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586882073; cv=none; d=google.com; s=arc-20160816; b=diO+KyFxQQ4gnO1OOnfMOqOnJT6XAaUQvh8CMniD3yxjSp1MyuZpsQQ9dQgKXvcS+4 sIoheV4iyzJobNi8mbG49Ikn/LILeCgUY/5Y1Cks/J10mGaIbE9MOql0v7qHzEY688WW jsLGKtNu908ie2RjNJbSZXCYCKGwLL30VvwG3rQXpXlVCJfT/07e/pemNgJMNnRcoIUB /PCuRY4f7M8n4LzR1MRyqVj0Bj7xlJsl4tLkwRe7sZZYO9P5YkZeLX/qZDfegb98LC27 i8QrdkGisece+ha8DQB9T9yUjaAI8cCyMJVn8DCqXENPDfhSyhyI0MKyZ9VbUhH5E0wD sfjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W7nJQJX9IoQnuaqukhZtsMTiQGsN/rCZM8XSZIP7IeU=; b=qH2JuN3VYPFskveDE9FWoF77vcsGC+aQLuQtzezQ2/v4qx8h4I2Pz7bk6dhLGtbrjr wjOP9gN8cwEAJvrwwtq5eLEUDN/EL/pZpyKvToy3VSL1kD0L8MpySmMaAeK+6SXTL6MP I3NebTDLjxbJH1QkYaVX1UDFdkHbFaj1ZFou+1GpEPrcFdA2nu2TxGsyYjPnN4xcN6q4 Z9iGGGHmIlTRHHVUJHXbTELDOq+IFl9Jk/wjWuh4UDRyfIEVfH4xarRFut0d4Q8R4Kdj gCW1TTexymseHmvXO8ou+aqDN0Zg/3NyqOykc8u3m0UXrBA6LQ1A3hIrzkWdBWDl9n6D UpAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VSImZCnQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si8617791edm.108.2020.04.14.09.34.09; Tue, 14 Apr 2020 09:34:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VSImZCnQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437212AbgDNPMn (ORCPT + 99 others); Tue, 14 Apr 2020 11:12:43 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:26305 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2436770AbgDNPHp (ORCPT ); Tue, 14 Apr 2020 11:07:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586876864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W7nJQJX9IoQnuaqukhZtsMTiQGsN/rCZM8XSZIP7IeU=; b=VSImZCnQhCUjN+MFNwxopyv01e1/oDrVw+6tgO3eE0UM+ktwhs1D4sSqo9ukmpHGsC+f8f u5l09hlXzzcO95Mw0obVDiLiJNlxOzF97y9BCErsaSl7WgWoqfZhc8YIDWscsqKwHw/Vp2 wJ3MmTRQlCbqh0Nh3NDj7E+pvBoH8ro= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-ILj7RUXzPaCrpnL8r3P_ew-1; Tue, 14 Apr 2020 11:07:42 -0400 X-MC-Unique: ILj7RUXzPaCrpnL8r3P_ew-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D18A801FAB; Tue, 14 Apr 2020 15:07:40 +0000 (UTC) Received: from laptop.redhat.com (ovpn-115-53.ams2.redhat.com [10.36.115.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 022FE271A3; Tue, 14 Apr 2020 15:07:29 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, joro@8bytes.org, maz@kernel.org, robin.murphy@arm.com Cc: jean-philippe@linaro.org, zhangfei.gao@linaro.org, shameerali.kolothum.thodi@huawei.com, alex.williamson@redhat.com, jacob.jun.pan@linux.intel.com, yi.l.liu@intel.com, peter.maydell@linaro.org, zhangfei.gao@gmail.com, tn@semihalf.com, zhangfei.gao@foxmail.com, bbhushan2@marvell.com Subject: [PATCH v11 08/13] iommu/smmuv3: Implement cache_invalidate Date: Tue, 14 Apr 2020 17:06:02 +0200 Message-Id: <20200414150607.28488-9-eric.auger@redhat.com> In-Reply-To: <20200414150607.28488-1-eric.auger@redhat.com> References: <20200414150607.28488-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Implement domain-selective and page-selective IOTLB invalidations. Signed-off-by: Eric Auger --- v7 -> v8: - ASID based invalidation using iommu_inv_pasid_info - check ARCHID/PASID flags in addr based invalidation - use __arm_smmu_tlb_inv_context and __arm_smmu_tlb_inv_range_nosync v6 -> v7 - check the uapi version v3 -> v4: - adapt to changes in the uapi - add support for leaf parameter - do not use arm_smmu_tlb_inv_range_nosync or arm_smmu_tlb_inv_context anymore v2 -> v3: - replace __arm_smmu_tlb_sync by arm_smmu_cmdq_issue_sync v1 -> v2: - properly pass the asid --- drivers/iommu/arm-smmu-v3.c | 53 +++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index 4ec2106be301..38854c3e4083 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -3413,6 +3413,58 @@ static void arm_smmu_detach_pasid_table(struct iom= mu_domain *domain) mutex_unlock(&smmu_domain->init_mutex); } =20 +static int +arm_smmu_cache_invalidate(struct iommu_domain *domain, struct device *de= v, + struct iommu_cache_invalidate_info *inv_info) +{ + struct arm_smmu_domain *smmu_domain =3D to_smmu_domain(domain); + struct arm_smmu_device *smmu =3D smmu_domain->smmu; + + if (smmu_domain->stage !=3D ARM_SMMU_DOMAIN_NESTED) + return -EINVAL; + + if (!smmu) + return -EINVAL; + + if (inv_info->version !=3D IOMMU_CACHE_INVALIDATE_INFO_VERSION_1) + return -EINVAL; + + if (inv_info->cache & IOMMU_CACHE_INV_TYPE_IOTLB) { + if (inv_info->granularity =3D=3D IOMMU_INV_GRANU_PASID) { + struct iommu_inv_pasid_info *info =3D + &inv_info->pasid_info; + + if (!(info->flags & IOMMU_INV_PASID_FLAGS_ARCHID) || + (info->flags & IOMMU_INV_PASID_FLAGS_PASID)) + return -EINVAL; + + __arm_smmu_tlb_inv_context(smmu_domain, info->archid); + + } else if (inv_info->granularity =3D=3D IOMMU_INV_GRANU_ADDR) { + struct iommu_inv_addr_info *info =3D &inv_info->addr_info; + size_t size =3D info->nb_granules * info->granule_size; + bool leaf =3D info->flags & IOMMU_INV_ADDR_FLAGS_LEAF; + + if (!(info->flags & IOMMU_INV_ADDR_FLAGS_ARCHID) || + (info->flags & IOMMU_INV_ADDR_FLAGS_PASID)) + return -EINVAL; + + __arm_smmu_tlb_inv_range(info->addr, size, + info->granule_size, leaf, + smmu_domain, info->archid); + + arm_smmu_cmdq_issue_sync(smmu); + } else { + return -EINVAL; + } + } + if (inv_info->cache & IOMMU_CACHE_INV_TYPE_PASID || + inv_info->cache & IOMMU_CACHE_INV_TYPE_DEV_IOTLB) { + return -ENOENT; + } + return 0; +} + static struct iommu_ops arm_smmu_ops =3D { .capable =3D arm_smmu_capable, .domain_alloc =3D arm_smmu_domain_alloc, @@ -3433,6 +3485,7 @@ static struct iommu_ops arm_smmu_ops =3D { .put_resv_regions =3D generic_iommu_put_resv_regions, .attach_pasid_table =3D arm_smmu_attach_pasid_table, .detach_pasid_table =3D arm_smmu_detach_pasid_table, + .cache_invalidate =3D arm_smmu_cache_invalidate, .pgsize_bitmap =3D -1UL, /* Restricted during device attach */ }; =20 --=20 2.20.1