Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp4579071ybb; Tue, 14 Apr 2020 10:00:17 -0700 (PDT) X-Google-Smtp-Source: APiQypI0J9KJbdXSwRLgS2quEUqr65Uh+f4SwD/tJNNoZUMKWUVujvCjaYsPAP1aXMjwNKFlPfIo X-Received: by 2002:a05:6402:b47:: with SMTP id bx7mr8673687edb.374.1586883617401; Tue, 14 Apr 2020 10:00:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586883617; cv=none; d=google.com; s=arc-20160816; b=D187+PWVskRYbXGjB5NBnsZNSYB3eeIws/mKzYNfMS/Gk3dR0ro/t0/lpDUehC0aMN KXdx1P5RqA/NMy3sbTB/tAVNiN2Rovl1LwCyChbaMcfxB0Q/QbryltYRPK9OjeiNLeNl O9zyR2CKLD/lRWkqrkLuhKxhdT2S7Bm3WW2FiuG4748ebpJq1qTT4fhn5+xvkzf3NQ4R MKpt/A7He8Omt2ZVDa4XZol5k3kfndMFZ2xbvgsxFQw4REWZkCjVjWFBI3IXqwnUJoUc R8SAjGb4fMFqMEkH3LZ2zlk4cbzS2ASHqtcaMfkopgDGHB3+/DMPn0MiYqw8vggDNmbk 90SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5ItLj3pw8ICgMslGV/jzi2WlPetpysNmexshbAM8+2Y=; b=HZ2GNW4oQmgdPgU+WJWBvibsrZbiLjY1GJk97d+V/UA6Bi09pX+6rboDuxrQ5edi6c CPKmKB3pryyVmwpUoBrdOMUIagMcln5YWKKZ+JKa77xfHGHSFwK8COuW5yZ4nOB1Z3ct ah/Q/q8868uuRpkO/dINyXO0P5eR6hXSaYkj8jB6L/4MJYqieizsoF/H37vLRSvQaqIX HKRwt3afBuc3kZEMfvkgJx82tI9TG+n93GRs0JyqhM+dDvBpxIBdWqvgFeklUslsEjPY 9t14tfVcvWM+zkirfG+X76dY6qud5wtxFiv855FIAs2HRGgHPd11CelGrtsYccJ+I8nd 2msA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fny7C1Jr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b12si9506180edy.329.2020.04.14.09.59.52; Tue, 14 Apr 2020 10:00:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fny7C1Jr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502279AbgDNQvw (ORCPT + 99 others); Tue, 14 Apr 2020 12:51:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:57368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440548AbgDNQvJ (ORCPT ); Tue, 14 Apr 2020 12:51:09 -0400 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 560FF2078A; Tue, 14 Apr 2020 16:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586883069; bh=5ItLj3pw8ICgMslGV/jzi2WlPetpysNmexshbAM8+2Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fny7C1Jr3lw6DvYP3P4R/o+BB7IEzN+oPJXzrc6U328xcACnDY2lLYiQIQ1D8udlH RsdBhYsL48o0lluaI4x/l7MwmKNVmKRfkBokxULYNsrxOKBzJuJnj6lOyW5qD5A2/K httZqYXw2vxiorpan5JMiddA56UtrnQzai215yAc= Received: by mail-lf1-f53.google.com with SMTP id t11so306501lfe.4; Tue, 14 Apr 2020 09:51:09 -0700 (PDT) X-Gm-Message-State: AGi0PuY9/+ju+XMBFLeorHKUymefpM0xCQfmOe2oPIuxbpyk+8X6hKVg WYG0YtYaA3papQwoO57o4VZZcnhvj+ivQDB7szQ= X-Received: by 2002:a19:494f:: with SMTP id l15mr434803lfj.33.1586883067437; Tue, 14 Apr 2020 09:51:07 -0700 (PDT) MIME-Version: 1.0 References: <1586779076-101346-1-git-send-email-zou_wei@huawei.com> In-Reply-To: <1586779076-101346-1-git-send-email-zou_wei@huawei.com> From: Song Liu Date: Tue, 14 Apr 2020 09:50:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH-next] bpf: Verifier, remove unneeded conversion to bool To: Zou Wei Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Networking , bpf , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 10:15 PM Zou Wei wrote: > > This issue was detected by using the Coccinelle software: > > kernel/bpf/verifier.c:1259:16-21: WARNING: conversion to bool not needed here > > The conversion to bool is unneeded, remove it > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Acked-by: Song Liu