Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [regression 5.7-rc1] System does not power off, just halts
From:   Paul Menzel <pmenzel@molgen.mpg.de>
To:     Prike Liang <Prike.Liang@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
        regressions@leemhuis.info, stable@vger.kernel.org,
        Mengbing Wang <Mengbing.Wang@amd.com>,
        Huang Rui <ray.huang@amd.com>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
References: <f4eaf0ca-6cd6-c224-9205-bf64ca533ff5@molgen.mpg.de>
Message-ID: <dcc4851e-0ab5-683a-2cf2-687d64a3c9da@molgen.mpg.de>
Date:   Mon, 13 Apr 2020 19:32:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <f4eaf0ca-6cd6-c224-9205-bf64ca533ff5@molgen.mpg.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dear Prike, dear Alex, dear Linux folks,


Am 13.04.20 um 10:44 schrieb Paul Menzel:

> A regression between causes a system with the AMD board MSI B350M MORTAR 
> (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just 
> to halt.
> 
> The regression is introduced in 9ebe5422ad6c..b032227c6293. I am in the 
> process to bisect this, but maybe somebody already has an idea.

I found the Easter egg:

> commit 487eca11a321ef33bcf4ca5adb3c0c4954db1b58
> Author: Prike Liang <Prike.Liang@amd.com>
> Date:   Tue Apr 7 20:21:26 2020 +0800
> 
>     drm/amdgpu: fix gfx hang during suspend with video playback (v2)
>     
>     The system will be hang up during S3 suspend because of SMU is pending
>     for GC not respose the register CP_HQD_ACTIVE access request.This issue
>     root cause of accessing the GC register under enter GFX CGGPG and can
>     be fixed by disable GFX CGPG before perform suspend.
>     
>     v2: Use disable the GFX CGPG instead of RLC safe mode guard.
>     
>     Signed-off-by: Prike Liang <Prike.Liang@amd.com>
>     Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
>     Reviewed-by: Huang Rui <ray.huang@amd.com>
>     Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>     Cc: stable@vger.kernel.org

It reverts cleanly on top of 5.7-rc1, and this fixes the issue.

Greg, please do not apply this to the stable series. The commit message 
doesn’t even reference a issue/bug report, and doesn’t give a detailed 
problem description. What system is it?

Dave, Alex, how to proceed? Revert? I created issue 1094 [1].


Kind regards,

Paul


[1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1094