Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Apr 2020 06:39:26 -0700
From:   'Christoph Hellwig' <hch@infradead.org>
To:     Alim Akhtar <alim.akhtar@samsung.com>
Cc:     'Christoph Hellwig' <hch@infradead.org>, robh@kernel.org,
        devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-samsung-soc@vger.kernel.org, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, krzk@kernel.org,
        kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org,
        'Seungwon Jeon' <essuuj@gmail.com>, stanley.chu@mediatek.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/5] scsi: ufs-exynos: add UFS host support for Exynos
 SoCs
Message-ID: <20200413133926.GA29228@infradead.org>
References: <20200412073159.37747-1-alim.akhtar@samsung.com>
 <CGME20200412074218epcas5p3ef7973c8a47533a15a359b069da8003c@epcas5p3.samsung.com>
 <20200412073159.37747-5-alim.akhtar@samsung.com>
 <20200412080947.GA6524@infradead.org>
 <000001d610e6$e8b11450$ba133cf0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000001d610e6$e8b11450$ba133cf0$@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Apr 12, 2020 at 09:54:53PM +0530, Alim Akhtar wrote:
> > So this doesn't actually require the various removed or not added quirks
> after
> > all?
> This driver is actual consumer of those quirks, so those are still needed.
> On Martin's 5.7/scsi-queue need to revert " 492001990f64 scsi: ufshcd:
> remove unused quirks"

No. You need to include one patch per quirk in your series to add them
back.  Please also follow all proper kernel style guidelines, as the
old code didn't always follow the proper style.