Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Apr 2020 11:44:44 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     =?UTF-8?B?5a6L54mn5pil?= <songmuchun@bytedance.com>
Cc:     mingo@kernel.org, peterz@infradead.org, juri.lelli@redhat.com,
        Vincent Guittot <vincent.guittot@linaro.org>,
        dietmar.eggemann@arm.com, Benjamin Segall <bsegall@google.com>,
        mgorman@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity
 functions
Message-ID: <20200413114444.5db76182@gandalf.local.home>
In-Reply-To: <CAMZfGtUY_GLXZ4jV4s0UZqsVF0W57dzUh0wVGynXYCy3CMN4iA@mail.gmail.com>
References: <20200406074750.56533-1-songmuchun@bytedance.com>
        <CAMZfGtUY_GLXZ4jV4s0UZqsVF0W57dzUh0wVGynXYCy3CMN4iA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 13 Apr 2020 23:07:03 +0800
宋牧春 <songmuchun@bytedance.com> wrote:

> > -void sched_init_granularity(void)
> > +void __init sched_init_granularity(void)
> >  {
> >         update_sysctl();
> >  }
> > --
> > 2.11.0
> >  
> 
> Ping guys. Any suggestions?

Seems fine, but not that big of an issue as it's a very small function.

ffffffff81136880 <sched_init_granularity>:
ffffffff81136880:       e8 7b b3 ac 00          callq  ffffffff81c01c00 <__fentry__>
                        ffffffff81136881: R_X86_64_PLT32        __fentry__-0x4
ffffffff81136885:       e9 86 86 ff ff          jmpq   ffffffff8112ef10 <update_sysctl>
ffffffff8113688a:       66 0f 1f 44 00 00       nopw   0x0(%rax,%rax,1)


But anyway, it can save 16 bytes of memory in the running kernel.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve