Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: dgilbert@interlog.com
Subject: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
To:     Markus Elfring <Markus.Elfring@web.de>,
        Li Bin <huawei.libin@huawei.com>, linux-scsi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        "James E. J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Xie XiuQi <xiexiuqi@huawei.com>
References: <8b5551e6-46e2-9def-8ab6-ec5ba252c5ea@web.de>
From:   Douglas Gilbert <dgilbert@interlog.com>
Message-ID: <0162f996-eb48-fda5-8355-1c9bc1162177@interlog.com>
Date:   Mon, 13 Apr 2020 21:39:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <8b5551e6-46e2-9def-8ab6-ec5ba252c5ea@web.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-13 3:35 p.m., Markus Elfring wrote:
>> Fix a memory leak when there have failed, that we should free the pages
>> under the condition rem_sz > 0.
> 
> I suggest to improve the change description.
> 
> * Please use an imperative wording.

nominative, vocative, accusative, genitive ...

I have made some comment suggestions in response to the original posts
from the author.

> * Will the tag “Fixes” become relevant?

Yes, both patches from the author are fixes. These leaks would typically
appear on a system under resource pressure (specifically low memory) and
would tend to make the situation worse.

Doug Gilbert