Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Reply-To: dgilbert@interlog.com
Subject: Re: [PATCH] scsi: sg: add sg_remove_request in sg_common_write
To:     Li Bin <huawei.libin@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        xiexiuqi@huawei.com
References: <1586777361-17339-1-git-send-email-huawei.libin@huawei.com>
From:   Douglas Gilbert <dgilbert@interlog.com>
Message-ID: <8a19ba1a-1afe-2938-daea-96b1f14570cf@interlog.com>
Date:   Mon, 13 Apr 2020 21:17:26 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1586777361-17339-1-git-send-email-huawei.libin@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-04-13 7:29 a.m., Li Bin wrote:
> If the dxfer_len is greater than 256M that the request is invalid,
s/that/then/
> it should call sg_remove_request in sg_common_write.
> 
> Fixes: f930c7043663 ("scsi: sg: only check for dxfer_len greater than 256M")

Code fix is fine, please replace the "that" in the first comment line
above with "then".

Acked-by: Douglas Gilbert <dgilbert@interlog.com>

> Signed-off-by: Li Bin <huawei.libin@huawei.com>
> ---
>   drivers/scsi/sg.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 4e6af592..9c0ee19 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -793,8 +793,10 @@ static int get_sg_io_pack_id(int *pack_id, void __user *buf, size_t count)
>   			"sg_common_write:  scsi opcode=0x%02x, cmd_size=%d\n",
>   			(int) cmnd[0], (int) hp->cmd_len));
>   
> -	if (hp->dxfer_len >= SZ_256M)
> +	if (hp->dxfer_len >= SZ_256M) {
> +		sg_remove_request(sfp, srp);
>   		return -EINVAL;
> +	}
>   
>   	k = sg_start_req(srp, cmnd);
>   	if (k) {
>