Date: Tue, 28 Feb 2006 10:17:13 -0800
From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@suse.cz>
Cc: rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Convert serial_core oopses to BUG_ON
Message-Id: <20060228101713.6fd44027.akpm@osdl.org>
In-Reply-To: <20060227141315.GD2429@ucw.cz>
References: <20060226100518.GA31256@flint.arm.linux.org.uk>
	<20060226021414.6a3db942.akpm@osdl.org>
	<20060227141315.GD2429@ucw.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1015
Lines: 34

Pavel Machek <pavel@suse.cz> wrote:
>
> 
> On Sun 26-02-06 02:14:14, Andrew Morton wrote:
> > Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > >
> > > Calling serial functions to flush buffers, or try to send more data
> > >  after the port has been closed or hung up is a bug in the code doing
> > >  the calling, not in the serial_core driver.
> > > 
> > >  Make this explicitly obvious by adding BUG_ON()'s.
> > 
> > If we make it
> > 
> > 	if (!info) {
> > 		WARN_ON(1);
> > 		return;
> > 	}
> > 
> > will that allow people's kernels to limp along until it gets fixed?
> 
> It will oops in hard-to-guess, place, anyway.

Will it?   Where?  Unfixably?

> BUG_ON is right.

WARN_ON+return is far better.  It keeps people's machines working until the
bug gets fixed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/