Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Apr 2020 00:18:42 +0200
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Ezequiel Garcia <ezequiel@collabora.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com, Hans Verkuil <hverkuil@xs4all.nl>,
        Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: Kconfig: Don't expose the Request API option
Message-ID: <20200415001842.7773610b@coco.lan>
In-Reply-To: <20200414220624.5396-1-ezequiel@collabora.com>
References: <20200414130210.18970-1-ezequiel@collabora.com>
        <20200414220624.5396-1-ezequiel@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, 14 Apr 2020 19:06:24 -0300
Ezequiel Garcia <ezequiel@collabora.com> escreveu:

> The Request API isn't meant to be chosen by users,
> but instead should be selected by drivers that want
> to support it.
> 
> Hantro and Cedrus are already selecting the right options,
> so only the test drivers need to be fixed.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  drivers/media/mc/Kconfig                   | 6 ++++--
>  drivers/media/test_drivers/Kconfig         | 2 ++
>  drivers/media/test_drivers/vicodec/Kconfig | 2 ++
>  drivers/media/test_drivers/vivid/Kconfig   | 2 ++
>  4 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/mc/Kconfig b/drivers/media/mc/Kconfig
> index 002a918c4c75..7c9628f37196 100644
> --- a/drivers/media/mc/Kconfig
> +++ b/drivers/media/mc/Kconfig
> @@ -2,7 +2,6 @@
>  
>  #
>  # Media controller
> -#	Selectable only for webcam/grabbers, as other drivers don't use it
>  #
>  
>  config MEDIA_CONTROLLER_DVB
> @@ -14,7 +13,7 @@ config MEDIA_CONTROLLER_DVB
>  	  This is currently experimental.
>  
>  config MEDIA_CONTROLLER_REQUEST_API
> -	bool "Enable Media controller Request API (EXPERIMENTAL)"
> +	bool
>  	depends on MEDIA_CONTROLLER && STAGING_MEDIA
>  	help
>  	  DO NOT ENABLE THIS OPTION UNLESS YOU KNOW WHAT YOU'RE DOING.

Hmm... I guess you can also remove the help here, as it won't be
shown anymore with make menuconfig.

Thanks,
Mauro