Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp215629ybz; Wed, 15 Apr 2020 07:27:22 -0700 (PDT) X-Google-Smtp-Source: APiQypJh3843Y0N/orFbSSf7NFL/IApmxb/fR1/QsEJktW7K97Yby+i9vY/u4hMz3ezaVydoBb9n X-Received: by 2002:a17:906:7d02:: with SMTP id u2mr5391535ejo.48.1586960841861; Wed, 15 Apr 2020 07:27:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586960841; cv=none; d=google.com; s=arc-20160816; b=TYH7Sf529WRD4CWW8w2Fpoik1Ap2CBelwAvVFxeyfsNfosGqn+D6BvZHU7mllOXijh IpYKXEaUz8x8XTmSDDd/MWbvb6rU8iSGG8R3uOEr9KfvYXZtnMazkAdNOfgKa9f4sZX3 UoJM00fGuApjZPEz5XCVOZcaxiv2joX/6NSIZnYae9EXBGQomgHux37gEQD8UmumMkRs xxYviFP/LOjrYOYw4PwgzG+JA8xV3F7+Yet3POyCopAJknuF8VjSePctTnsUH3zwIW0u IQMG7+6Hl5bxd7A/aOntZGvv9psWQS0zkk89zNrqeladtXI3xRBXwxPV2MrpGm7FzTJy h+fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EF11WfQVnD9UTOZQHwLCz7V4fPkuL/l2xmqk1xxRd88=; b=BfJL2f4HoDBua3HwENzCK0ieH1wk9IrtZOCASFHUefEcG/3PZKBThGEn3Orbc+dBqe JZjcmnbnTVF5ZkTjeOTt7nhzoXcjyVIMNCel5MFBoN3b/pcpZ5j9M4x7lKdCMTEdZN2A luityU0bpbWBKtgCePSqmiZ4VSpTxfzVaUcGA/7Ygo42i/BS8mS9C4E4r13dldu0ocXW 0udyiTetKnT7+hxICI86iIuX3WOUjVa8AKtrvzKM6vdGCRJmenD41C5p9AM6hHDiibjg QRGQjLYj1RIgzDuq9ZSXosrWfsjnGGgxxxqDCZ8Ce7uc8HP/4y86GUNd7GT7BH4vEE0R xIWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MqZrnHNZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oo21si5875812ejb.453.2020.04.15.07.26.50; Wed, 15 Apr 2020 07:27:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MqZrnHNZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634326AbgDNW6c (ORCPT + 99 others); Tue, 14 Apr 2020 18:58:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2634321AbgDNW62 (ORCPT ); Tue, 14 Apr 2020 18:58:28 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52153C061A0C for ; Tue, 14 Apr 2020 15:58:27 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id v23so662577pfm.1 for ; Tue, 14 Apr 2020 15:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EF11WfQVnD9UTOZQHwLCz7V4fPkuL/l2xmqk1xxRd88=; b=MqZrnHNZ7XofH+r983WLDOJb7uvqqwBHnwLjioaZAViwpvOMBOOh3c1mvmzN4tg5Ao 0MSZjzPNc53ywbOHV4rpEpGt/dVAwarzcMCW1P4ziNkDNAVl8FTrgU8adOTXA7F8xxSK e44q4agun5bEPcUgwk01nbBPH4Hs3cNqTr7ZUTranDNkOMKBCqX6pkks95GrsPEWTkmp Z/vRdRFfDfwp67oevd8oouTuL0AKu6+qscORta066PANcNTjqLi5RmZyf+dUbA48847j TCrsM5mE8GqdkA2+1bf7ePi8p+Vu+95k74Fvw6qlUO3In8j30isooIeaLzH37Y7UOAHn v13w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EF11WfQVnD9UTOZQHwLCz7V4fPkuL/l2xmqk1xxRd88=; b=f9iNoxGZ8T3u1e9Z/zXgUmOeLbsiqsrTnPN2RaGnugNt6ERXtVr4OI3R81MaffdtqL 9GRl2OgRlPWgqxGFjDplDwJ+3NYNkxNa+QwFLKgweQ7XoPcn6jEHzib+5kXy3DXp3uw/ YRxwEUQswd2QvTyuhGWiGyeU/7G/DI8YD2hV8QRz7bcYlnEreh126ink03UJwJiTkCoB OgW1/q2GoP7rUreheWSaoPzm4+up454MdvBdJ5oRoSIoUbmw+HdDkdfzJtq2LWlWe3c4 fmjXBerF0gl2AtlCR53zslZ+MENOSZbNd+cuvQWOymem+i2rnDHjfMtobAVcnUYAxfxQ 8sbA== X-Gm-Message-State: AGi0PuaUWWLkjGsDjefyBy9p+jhQJ2RkWEjiX1L0632byTMCZIYlWWI2 CnroyjF7I8RrwPlD8iF8KCem8NmibCg= X-Received: by 2002:aa7:95ae:: with SMTP id a14mr23692405pfk.164.1586905106770; Tue, 14 Apr 2020 15:58:26 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i190sm10122359pfc.119.2020.04.14.15.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 15:58:26 -0700 (PDT) Date: Tue, 14 Apr 2020 15:58:23 -0700 From: Bjorn Andersson To: Wang Wenhu Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org, kernel@vivo.com, agross@kernel.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3,0/3] drivers: rpmon: new driver Remote Processor Monitor Message-ID: <20200414225823.GH892431@yoga> References: <20200412112405.24116-1-wenhu.wang@vivo.com> <20200414035949.107225-1-wenhu.wang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414035949.107225-1-wenhu.wang@vivo.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 13 Apr 20:59 PDT 2020, Wang Wenhu wrote: > RPMON is a driver framework. It supports remote processor monitor > from user level. The basic components are a character device > with sysfs interfaces for user space communication and different > kinds of message drivers introduced modularly, which are used to > communicate with remote processors. > > As for user space, one can get notifications of different events > of remote processors, like their registrations, through standard > file read operation of the file descriptors related to the exported > character devices. Actions can also be taken into account via > standard write operations to the devices. Besides, the sysfs class > attributes could be accessed conveniently. > > Message drivers act as engines to communicate with remote processors. > Currently RPMON_QMI is available which uses QMI infrastructures > on Qualcomm SoC Platforms. > > RPMON_QMI implements a kind of communication routine for RPMON to > communicate with remote processors through QMI infrastructure. > RPMON_QMI itself is designed as a modular framework that would > introduce different kind of message sets which are binding to > different services. > > RPMON_QMI creates a device of rpmon_device type for each remote > processor endpoint. All the endpoint devices share an unique set > of QMI suite. > > RPMON_QMI_MSG_V01 implements a RPMON_QMI message set for connection check. > RPMON_QMI defines its message types modularly. Each rpmon service > binds to a message set and introduced as a module. This version 1.0 > message set could be used for connection checking of remote processors. > > RPMON_QMI messages depend on QCOM_QMI_HELPERS and should be updated > together with QMI related modules. > Hi Wang, What additional transports do you expect for this to be a framework and not just a driver? Why not implement the rpmon client directly in userspace? Regards, Bjorn > Changes since v1: > - Addressed review comments from Randy > Changes since v2: > - Added Cc list > - Commit log typo fixing > - Use the ARRAY_SIZE instead of calculations of multiple sizeof() > - Use micros for qmi message tly_type fields > > Wang Wenhu (3): > driver: rpmon: new driver Remote Processor Monitor > driver: rpmon: qmi message version 01 > driver: rpmon: add rpmon_qmi driver > > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/rpmon/Kconfig | 54 ++++ > drivers/rpmon/Makefile | 3 + > drivers/rpmon/rpmon.c | 506 +++++++++++++++++++++++++++++++ > drivers/rpmon/rpmon_qmi.c | 431 ++++++++++++++++++++++++++ > drivers/rpmon/rpmon_qmi.h | 76 +++++ > drivers/rpmon/rpmon_qmi_msg_v1.c | 258 ++++++++++++++++ > include/linux/rpmon.h | 68 +++++ > 9 files changed, 1399 insertions(+) > create mode 100644 drivers/rpmon/Kconfig > create mode 100644 drivers/rpmon/Makefile > create mode 100644 drivers/rpmon/rpmon.c > create mode 100644 drivers/rpmon/rpmon_qmi.c > create mode 100644 drivers/rpmon/rpmon_qmi.h > create mode 100644 drivers/rpmon/rpmon_qmi_msg_v1.c > create mode 100644 include/linux/rpmon.h > > -- > 2.17.1 >