Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp233914ybz; Wed, 15 Apr 2020 07:47:46 -0700 (PDT) X-Google-Smtp-Source: APiQypLF1WL5PX7fW2s9icB0Iww/DXsu67gx6qvndtje9FwxKj9NnRvAPF+VxXY5soODbqtpEv0h X-Received: by 2002:a17:906:1641:: with SMTP id n1mr5398506ejd.365.1586962066081; Wed, 15 Apr 2020 07:47:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586962066; cv=none; d=google.com; s=arc-20160816; b=YM5WGGulsqLSLa19CrL7DZQ+d9hf51hLTlD736cxmo5Tq+pw5e0ENC3GaMJ4Ff9QF/ VS5ib5+0K+/SF4dh6EN0QnP5B9covzoJgtpg+lBQfFqbMN0ndLU5VCwXNnIZ00sd5DXE QwWYq7DYNjdVoFGQKGwD3VQoIQm36+MyihpU76Sf731C2JiH5foXAM3GopGrDKzjk6E+ dW4bmu84dkOYtDklai2BCiGqXYIv1856Lmd+e6K8Zqv9p/ri+Dah/xkLAloVwPbSJ/je mE4+CTdQYWcaJP7yQMqMg3eNTAWsaOpiYh/Cnn9XAodE2pDQwz8GQTckbaw45EgeKsk9 e2YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=WmbYu2O3yF2wXYEPuVo8l8V7RANT+hNBcsLrEVAvWvE=; b=pV9OfmF69zS5C7cUBI5Fx9nA19+2BWJpAvhldGom41CMVSYq71g6C/XNVGdoNqgsiv cffNEkQJYzl/aLDhfJdQ8vDWBbXnLzSwtqJt0/ucdMj6SszLKN/58TcVrs2MdeSJFtpM 8VyHTMXwtbVIaDiYg3T8unpC3AtMbeQK7TA6V50nrWidv+yg7sqlBkSN9LvgOYypelme +FuzulgLmn4b1KvLToTJwgJL9DZfOvFfK0Css0jCjJK3gvK7GIF8eISmSifqwi9+2Xf/ s+9hFmfX5QunGsMm37lBJk+4XNZM1C2cgjN9E6prQlb1tJ5GteMIxX+Rquks/9f6Iwj9 bSQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=D097tOZ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id aq18si11078726ejc.201.2020.04.15.07.47.21; Wed, 15 Apr 2020 07:47:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=D097tOZ+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392734AbgDOBrp (ORCPT + 99 others); Tue, 14 Apr 2020 21:47:45 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:41738 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387783AbgDOBrZ (ORCPT ); Tue, 14 Apr 2020 21:47:25 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03F1gxkc085152; Wed, 15 Apr 2020 01:46:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=WmbYu2O3yF2wXYEPuVo8l8V7RANT+hNBcsLrEVAvWvE=; b=D097tOZ+I4fXRykoTeLhImIAuGQ4bxoXDkc330roQnOntNmZADxEwc8WIP5PXIQQbO/q nudRe2fAQ73IWZpVbICJ1k0hvg/KiuKdJeQQhNoLonCLdJARAFOqchAIGwpYMaYCmPWA q4A2x0xSkcrisB8qduBZDQ/DynB9dqSpnUBpbD+9R7Gy2CCRdGGGNy6BTkKkA7LfYfhe QtRSpmeAlpXkP1db012vLMgrbAXunOr1DhY+GxgoZ6vnXGsVNeo3OFAEb9Lsg1C7Xc7i uclbJfaOmH/SEsEGyDGoKd0WYbtIgrup29+GuZEQ1UMlst5GqDKIyflkMjkjQMYanm/5 yA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 30dn9cgmjd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Apr 2020 01:46:44 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03F1flhc017905; Wed, 15 Apr 2020 01:44:44 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 30dn98g6tn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Apr 2020 01:44:44 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 03F1ifdg020838; Wed, 15 Apr 2020 01:44:41 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 Apr 2020 18:44:41 -0700 To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, "James E.J. Bottomley" , "Martin K. Petersen" , John Garry , Allison Randal , Hannes Reinecke , Thomas Gleixner , linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM) Subject: Re: [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200411001933.10072-1-jbi.octave@gmail.com> <20200411001933.10072-7-jbi.octave@gmail.com> Date: Tue, 14 Apr 2020 21:44:38 -0400 In-Reply-To: <20200411001933.10072-7-jbi.octave@gmail.com> (Jules Irenge's message of "Sat, 11 Apr 2020 01:19:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9591 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 mlxlogscore=965 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004150009 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9591 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004150009 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jules, > Sparse reports a warning at sas_ata_qc_issue() > > warning: context imbalance in sas_ata_qc_issue() - unexpected unlock > The root cause is the missing annotation at sas_ata_qc_issue() > > Add the missing __must_hold(ap->lock) annotation Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering