Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Xdzih+kU46ceIYw9T+hfpavmsDBJtylee84zd1JoMTUPmUKaBaMClpq5IwBw5vNC6cXwo9y7He
 oBhBrXAEO65g==
IronPort-SDR: XI465BG+7j67qXFLT9dIcHvFNQBQDHurw6IfghYezG/NpWEdYCVIsNDT2k6ZC1QusTyPJdtTbR
 h6Ep06sJKl6g==
Subject: Re: [PATCH v1 2/2] mtd: rawnand: Add NAND controller support on Intel
 LGM SoC
To:     Boris Brezillon <boris.brezillon@collabora.com>
Cc:     linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
        devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
        richard@nod.at, vigneshr@ti.com, arnd@arndb.de,
        brendanhiggins@google.com, tglx@linutronix.de,
        anders.roxell@linaro.org, masonccyang@mxic.com.tw,
        piotrs@cadence.com, robh+dt@kernel.org,
        andriy.shevchenko@intel.com, qi-ming.wu@intel.com,
        cheol.yong.kim@intel.com
References: <20200414022433.36622-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200414022433.36622-3-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200414092132.525053f1@collabora.com>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <bb9d2f29-acef-cc1b-8606-bbb38b488cce@linux.intel.com>
Date:   Wed, 15 Apr 2020 14:01:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200414092132.525053f1@collabora.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Boris,

     Thank you so much for review comments and your time...

On 14/4/2020 3:21 pm, Boris Brezillon wrote:
> Hello Ramuthevar,
>
> On Tue, 14 Apr 2020 10:24:33 +0800
> "Ramuthevar,Vadivel MuruganX"
> <vadivel.muruganx.ramuthevar@linux.intel.com> wrote:
>
>> +	lgm_host->chip.legacy.read_byte = lgm_read_byte;
>> +	lgm_host->chip.legacy.read_buf = lgm_read_buf;
>> +	lgm_host->chip.legacy.write_buf = lgm_write_buf;
>> +	lgm_host->chip.legacy.select_chip = lgm_select_chip;
>> +	lgm_host->chip.legacy.dev_ready = lgm_dev_ready;
>> +	lgm_host->chip.legacy.cmd_ctrl = lgm_cmd_ctrl;
>> +	lgm_host->chip.legacy.chip_delay = 30;
>> +	lgm_host->chip.legacy.dummy_controller.ops = &lgm_nand_controller_ops;
>> +
> Seriously, what's not clear in [1]? Okay, let's say you overlooked this
> comment, isn't the name of the field explicit enough? We received a
> few other drivers implementing the legacy interface in the last few
> months so maybe there's something to improve on our end (update the
> doc, move legacy drivers to a legacy sub-dir?).
Understood the legacy to latest implementation based ->exec_op(), Thanks!
>
> Back to more constructive comment now: please implement ->exec_op() to
> replace those legacy hooks.

Agreed, will do the implementation of exec_op() hook and update the patches.

Regards
Vadivel
>
> Regards,
>
> Boris
>
> [1]https://elixir.bootlin.com/linux/v5.7-rc1/source/include/linux/mtd/rawnand.h#L987