Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp264625ybz; Wed, 15 Apr 2020 08:20:12 -0700 (PDT) X-Google-Smtp-Source: APiQypIYMPjeBCaZgSqMhcRk13v/pZDivy/Bi8L4KKU/cw3W7+iW9zP9OPxo17tdfs5kyYHnIlap X-Received: by 2002:a17:906:6444:: with SMTP id l4mr5270544ejn.313.1586964012740; Wed, 15 Apr 2020 08:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586964012; cv=none; d=google.com; s=arc-20160816; b=Gv1RlZyjrlR37UmEGsBpslNZRNP0Il+alYJvoDWsFXBpQr3iZzfQOnTwFA1ifdC3Hi vlEF99T8q+9pkpGpiQGwvbzzWB+REFWn7atTveZfKk8QnnYhssplhhCDAieLNqnwlfa9 1BBNxl2XWXn6e+7uxlDsGp8QexLRq6eDGbjVubTW3Tt7kHq1CVLVXA0eaoZFWf1H+wE6 Xg8RaOW5Wqu8jWLYjix5/2ZdHyeP52sEDXj4ajDgitPIeCBAZ4X2OuCqjXr2Dm6lqsTk OO91V6EwgQAoH/0hHeZhOfKyjj5GslD1uhnmGvAjXjJIv0y+bSnLeYbOT0UYqTraXbT9 b+Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CH5rFkjMsn+0QMb/vSOIM/4sxR6H6rx4eQE3M7V0o64=; b=I66WMUXouBcARhNjcEV2MKhIlTFAcQIOjPLb8bVfO+8Ca3X985HV9A5jvuVxTzuHDx 5xkJejzxLHP2ZSzgXCWFmsHQf9bLQ+O6w52jLueIKg7Smkoa9J7Dv9fscJsDL4Da9TGf s/CiXMXdZg5jfqtFatIQVCO9hsb7qAlgVBWFRlhKXaFPpdVPv2XTBkpqMw82gachBghZ hQYwltSH7oxuaniz34gKufwuX3sW3X6TdtUkaXUmWja7LjHgSJUExTDRY+RZRUZa7K19 XAo3oxmICySCtmnz/1W3ZcvmnEr/xGjqfcMB2VQHO0Om9ZUY6jgn9c2FhL59Xc7qA3TE MsCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sa4si11259835ejb.69.2020.04.15.08.19.49; Wed, 15 Apr 2020 08:20:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634773AbgDOGTI (ORCPT + 99 others); Wed, 15 Apr 2020 02:19:08 -0400 Received: from verein.lst.de ([213.95.11.211]:43521 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393532AbgDOGTG (ORCPT ); Wed, 15 Apr 2020 02:19:06 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C3C0368C65; Wed, 15 Apr 2020 08:18:59 +0200 (CEST) Date: Wed, 15 Apr 2020 08:18:59 +0200 From: Christoph Hellwig To: Alexey Kardashevskiy Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Lu Baolu , Greg Kroah-Hartman , Joerg Roedel , Robin Murphy , linux-kernel@vger.kernel.org, Michael Ellerman Subject: Re: [PATCH 1/4] dma-mapping: move the remaining DMA API calls out of line Message-ID: <20200415061859.GA32392@lst.de> References: <20200414122506.438134-1-hch@lst.de> <20200414122506.438134-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 12:26:04PM +1000, Alexey Kardashevskiy wrote: > May be this is correct and allowed (no idea) but removing exported > symbols at least deserves a mention in the commit log, does not it? > > The rest of the series is fine and works. Thanks, Maybe I can throw in a line, but the point is that dma_direct_* was exported as dma_* called them inline. Now dma_* is out of line and exported instead, which always was the actual API.