Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp483073ybz; Wed, 15 Apr 2020 12:28:14 -0700 (PDT) X-Google-Smtp-Source: APiQypIVI1YVmnT/llHju0q83KBHzDoX1tWTR0QsXzYtsfyyOW04OtyWhNgkXj5VNjjpAERiZjfk X-Received: by 2002:a50:c3c2:: with SMTP id i2mr7234654edf.93.1586978894162; Wed, 15 Apr 2020 12:28:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586978894; cv=none; d=google.com; s=arc-20160816; b=JN9Hqm8s1qXCNpbo7Ojos1fJVbuoDvJ9mVAbb/gRMFGVmt2cJ/PL1uBocECCK/RRdA v254uyNQT11K9LjU9SFIhg7dUB/UkiGnXKKpZTHhnLlFGCVd8MrTboWu3LKZr8ryaWAe PfClgnEsEZsu0cqxWgte5hSg4qfoB9jo8ROVTXkK2LR/wtohbuYSHncImBK5m22rG/Q5 9I7+K+8OHNzvBxA6ToHvu+WRVWul6/x1dI29t5mdmAfWSDAJ3Anq1+jLxI+iXLytijz0 ZrwDXBA9GFG6jXACBp5vKJZuk0vKeY4TR4f9jmKUyQ24kiWjWPUf4l6Q6WuCVeV4vBn4 SDLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qgtGpgdzt5HYwy3uBfgzSIvORQYDEwmO+Ki/gxjvqms=; b=x3qMjOFJU6U3mtYYcJ7odihUCnZnSNYuL5ZN7GhfKjcZffkhthZ3E2IFWO9ngpqVNB rl9+X7SkB0x6Jv3hr3D8z0zGRVe/3nKkYhmXcaQ/jJCcP2/KaH6n4X6VTDMb5nJJ1FXV bJSiBu1fC1D78MuXZeO0sOUIMTD1d/AB4+qODXfIXeyfcYFaUrLB0/D0bqR7nvMQaivU kJxrG2xwZ7BT2BA5RNcxpeU+/ARJw1PUMGByD2oIe3GMuLtAERJ0CyVVAtxjmAEYdVgr Q1l/AdFaX4PZTG10tv1lMvxQwW5r/zPoKpY+TISFnTprGeL1OkbVwP+o71VvMdsjwF6v 2YUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si11296098edf.135.2020.04.15.12.27.49; Wed, 15 Apr 2020 12:28:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436694AbgDNIYb (ORCPT + 99 others); Tue, 14 Apr 2020 04:24:31 -0400 Received: from foss.arm.com ([217.140.110.172]:50778 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436548AbgDNIWB (ORCPT ); Tue, 14 Apr 2020 04:22:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82AE91FB; Tue, 14 Apr 2020 01:21:57 -0700 (PDT) Received: from bogus (unknown [10.37.12.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 539AC3F73D; Tue, 14 Apr 2020 01:21:48 -0700 (PDT) Date: Tue, 14 Apr 2020 09:21:36 +0100 From: Sudeep Holla To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, dietmar.eggemann@arm.com, Thomas Bogendoerfer , Huacai Chen , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Florian Fainelli , Robert Richter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Daniel Lezcano , Thomas Gleixner , Jason Cooper , Marc Zyngier , Paul Burton , Allison Randal , Enrico Weigelt , Kate Stewart , Vladimir Kondratiev , Alexios Zavras , Paul Cercueil , Zhou Yanjie , =?utf-8?B?5ZGo55Cw5p2wIChaaG91IFlhbmppZSk=?= , YunQiang Su , Arnd Bergmann , Serge Semin , Matt Redfearn , Richard Fontana , Steve Winslow , afzal mohammed , Peter Xu , Mike Rapoport , Kamal Dasu , Oleksij Rempel , Sudeep Holla , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, oprofile-list@lists.sf.net, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 01/11] MIPS: setup: Drop prefill_possible_map Message-ID: <20200414082123.GA6459@bogus> References: <20200412032123.3896114-1-jiaxun.yang@flygoat.com> <20200412032123.3896114-2-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200412032123.3896114-2-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 12, 2020 at 11:20:31AM +0800, Jiaxun Yang wrote: > All the plat_smp_setup are setting up possible cpus in their > platform code. So prefill_possible_map is actually overwriting > platform's setup, which seems unreasonable. > Why don't you rearrange the code so that this still remains as is and the platforms can override if they need. If you do so, you don't need the change in 04/11 as I suggested previously. -- Regards, Sudeep