Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Apr 2020 12:57:23 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     Peng Wang <rocking@linux.alibaba.com>,
        Ingo Molnar <mingo@redhat.com>, uri.lelli@redhat.com,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: Simplify the code of should_we_balance()
Message-ID: <20200414105723.GN20713@hirez.programming.kicks-ass.net>
References: <245c792f0e580b3ca342ad61257f4c066ee0f84f.1586594833.git.rocking@linux.alibaba.com>
 <CAKfTPtBLc7Y-a-nuXF-p8wEaJQLiQn4crOg6R0Z4NBJ64yMLBg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKfTPtBLc7Y-a-nuXF-p8wEaJQLiQn4crOg6R0Z4NBJ64yMLBg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 14, 2020 at 09:25:00AM +0200, Vincent Guittot wrote:
> On Sat, 11 Apr 2020 at 11:21, Peng Wang <rocking@linux.alibaba.com> wrote:
> >
> > We only consider group_balance_cpu() after there is no idle
> > cpu. So, just do comparison before return at these two cases.
> >
> > Signed-off-by: Peng Wang <rocking@linux.alibaba.com>
> 
> With the small fix in the comment below

Done

> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

Thanks Guys!