Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: UYGi80TwhA9fSDubrh1GgtNxXZngVhPTsuXqUhEyRd36L5SqDL3BZxVFHIQfPXFIyKt+tMBIK/
 LIGJYXm7inYA==
IronPort-SDR: pA7/gJMubPfJMQ+e+plvninRb7LQT9IuPX6aKRV0HMneYUaN57/nWrJxnfeeFNVC9hvq+8bQLQ
 FC3QtUzAYLdQ==
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     James Hilliard <james.hilliard1@gmail.com>,
        dri-devel@lists.freedesktop.org
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        James Hilliard <james.hilliard1@gmail.com>,
        linux-kernel@vger.kernel.org,
        "Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] component: Silence bind error on -EPROBE_DEFER
In-Reply-To: <20200411054106.25366-1-james.hilliard1@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20200411054106.25366-1-james.hilliard1@gmail.com>
Date:   Tue, 14 Apr 2020 14:07:01 +0300
Message-ID: <87lfmymilm.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 10 Apr 2020, James Hilliard <james.hilliard1@gmail.com> wrote:
> If a component fails to bind due to -EPROBE_DEFER we should not log an
> error as this is not a real failure.
>
> Fixes:
> vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517
> vc4-drm soc:gpu: master bind failed: -517

I'd think the probe defer is useful information anyway. Maybe just tone
down the severity and/or the message?

BR,
Jani.

>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  drivers/base/component.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/component.c b/drivers/base/component.c
> index e97704104784..157c6c790578 100644
> --- a/drivers/base/component.c
> +++ b/drivers/base/component.c
> @@ -256,7 +256,8 @@ static int try_to_bring_up_master(struct master *master,
>  	ret = master->ops->bind(master->dev);
>  	if (ret < 0) {
>  		devres_release_group(master->dev, NULL);
> -		dev_info(master->dev, "master bind failed: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_info(master->dev, "master bind failed: %d\n", ret);
>  		return ret;
>  	}
>  
> @@ -611,8 +612,10 @@ static int component_bind(struct component *component, struct master *master,
>  		devres_release_group(component->dev, NULL);
>  		devres_release_group(master->dev, NULL);
>  
> -		dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
> -			dev_name(component->dev), component->ops, ret);
> +		if (ret != -EPROBE_DEFER) {
> +			dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
> +				dev_name(component->dev), component->ops, ret);
> +		}
>  	}
>  
>  	return ret;

-- 
Jani Nikula, Intel Open Source Graphics Center