Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp585210ybz; Wed, 15 Apr 2020 14:34:06 -0700 (PDT) X-Google-Smtp-Source: APiQypKxh2ydbqrXfoN5d8eUxg4HGnXm+Xu99wPAKiOvb0FOUm9hsEflpHMYmK8sSAWfqODJiunW X-Received: by 2002:aa7:cb0f:: with SMTP id s15mr494213edt.164.1586986446403; Wed, 15 Apr 2020 14:34:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586986446; cv=none; d=google.com; s=arc-20160816; b=qg8vHPzuxDZbnvskL6MtfUFhFKwN5lSThzSPMkhIcWf2QDUQSVAz9kDkN641wmR7V3 iXYU/nzUNdn1sIUEXVKRV3m4w+6ZR071U4N/TrQdtlqpor+HTwi2HY+d8qmBht9nt2tv sFoQLNyHLd3RTPwiUdZGhN1+sMmXgeU2KCbYgpupTle5Ow7Jncnll6SEK3AYVF2Kt1/n 06Zxliz1ETYS6pbYkd+zZBJaWOz84u7EWRnFkvcClS6pIIE3+g9rHRjgmUbeFFv2q2+e ovYkM7TR/ZFr+/d94RBXMaq+yNjC0cMY8KDAuUbmBeb2VAmrEuyPD0os+cjTxTE8svUb +rdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=UuhTnNwJTWdRU0xEDU6kU99690p9xzRREuCrP3gtOcs=; b=aYG1tgZFA7ovg21txrOn59X1zHrj3bzZbp8b8mLthmWbs6r/Re9XNb86OiDCg+V3sV oEoMYB7ffFTOCHKTr4kBnYj0zEGRzqzQ/jFnejsGmH079kSitzZJtj4s2Jbk9RWzjDR2 my4dUKviZP78tl77D5VqcTrp/yycv28XX+P2OvLSHv2tDIo9FlaXzFvbzwc+YDIJwoZ1 DpO77c/cR9MwoSmXvbYfAuMN4GtT9yHsE/GvJ2Iy/jRnhGRZ/3cDKuLeUujYaWyTEita Bu+GeVid/oNbfW9t75+gb3lT37PTGGEJpnm3CDhXQMnMcj5llwldmX1TAGkZft3c4F5W w1Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j24si6267390edt.64.2020.04.15.14.33.43; Wed, 15 Apr 2020 14:34:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731493AbgDNNXA (ORCPT + 99 others); Tue, 14 Apr 2020 09:23:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731120AbgDNNUd (ORCPT ); Tue, 14 Apr 2020 09:20:33 -0400 X-Greylist: delayed 277 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 14 Apr 2020 06:20:32 PDT Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED76DC061A0C; Tue, 14 Apr 2020 06:20:32 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 340BE45B; Tue, 14 Apr 2020 15:20:31 +0200 (CEST) Date: Tue, 14 Apr 2020 15:20:29 +0200 From: Joerg Roedel To: Marek Szyprowski Cc: Will Deacon , Robin Murphy , Kukjin Kim , Krzysztof Kozlowski , David Woodhouse , Lu Baolu , Andy Gross , Bjorn Andersson , Matthias Brugger , Rob Clark , Heiko Stuebner , Gerald Schaefer , Thierry Reding , Jonathan Hunter , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel Subject: Re: [PATCH] iommu/exynos: Get rid of 'struct exynos_iommu_owner' exynos_iommu_owner Message-ID: <20200414132029.GB14731@8bytes.org> References: <20200407183742.4344-1-joro@8bytes.org> <20200407183742.4344-32-joro@8bytes.org> <449e7f16-e719-9617-ec92-63b82c0bc33f@samsung.com> <20200409114620.GA16298@8bytes.org> <40af831b-d00c-0cf9-0a06-e60c048a9ab8@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40af831b-d00c-0cf9-0a06-e60c048a9ab8@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 03:58:00PM +0200, Marek Szyprowski wrote: > I've checked and it works fine on top of > ff68eb23308e6538ec7864c83d39540f423bbe90. However I'm not a fan of > removing this 'owner' structure. It gave a nice abstraction for the all > SYSMMU controllers for the given device (although most devices in the > system have only one SYSMMU). Why this structure is a problem for your > rework? Okay, the structure itself is not a problem, I just thought it is not really necessary. But to keep things simple I've taken another approach for v2 of this series: Just use the first SYSMMU of the controllers list to link the device and the IOMMU. When the owner structure exists there is always one entry in this list, so that should work fine. Regards, Joerg