Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log
 size
To:     Sarthak Kukreti <sarthakkukreti@chromium.org>, bleung@chromium.org
Cc:     keescook@chromium.org, anton@enomsg.org,
        linux-kernel@vger.kernel.org, ccross@android.com,
        tony.luck@intel.com, gwendal@chromium.org
References: <20200402001548.177025-1-sarthakkukreti@chromium.org>
Message-ID: <31fceb88-0d0d-083a-ce4d-3ebba1822a40@collabora.com>
Date:   Tue, 14 Apr 2020 15:14:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200402001548.177025-1-sarthakkukreti@chromium.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sarthak,

Thank you for your patch.

On 2/4/20 2:15, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
> 
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
> ---

Applied for 5.8

>  drivers/platform/chrome/chromeos_pstore.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
>  	.record_size	= 0x40000,
>  	.console_size	= 0x20000,
>  	.ftrace_size	= 0x20000,
> +	.pmsg_size	= 0x20000,
>  	.dump_oops	= 1,
>  };
>  
>