Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp587516ybz; Wed, 15 Apr 2020 14:37:13 -0700 (PDT) X-Google-Smtp-Source: APiQypIf5tcPPe55aL3NzTWBQxrXBk7XqEoFprBcYYHbQaJW57y+9vz0Vo4HCvZNg9kCl0FF4z3U X-Received: by 2002:a17:906:5003:: with SMTP id s3mr6782529ejj.266.1586986633316; Wed, 15 Apr 2020 14:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586986633; cv=none; d=google.com; s=arc-20160816; b=E99XdDt7yVrt5CVw2KQR5N9fB4//wKejSFx0ALcrrrhlmKHBElxmACYgRbEu8mFmhi NB5t7GBsJra9Y/aCSSor/wtHax9MpFCHFVRCnwpTHCG6tKihOI9i9HXG4qd5qDiNnAdl 37zZDjGB0vC8mCd129kdQfAHHXkuaNYZEUnYks2w9szAyC1ftqyNZyep8WeLNTgaVnDA 0y4wqijlzPHe5GQ9KJ6chX/EmD0P8dZPrGFSq2Hfvx/80a4WttU9FodyHD8Ev1fdg2C7 fPSsrxjG7+C/EXYgWR3ztHZ6g/xjZP21fJ6yc7GxlmYKyymMZvCmaXTPPnnLmRtrivu1 9ZEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=aWpu9nPYT6BLJvo9uNJvy8ljRewTSwDwA2l0GKEqL08=; b=hYuyZExlrJ9w8HOgp2oqZwB2aU7JfTAkA2eoVhgfjA0w29j0BGGgGvyUtSdNjnGSWZ t16fUWus8euAWJikYaucay4fc/G127QGHI9JZqpOaYUHJVH+6VEW1rSiIvlm3zw8pq6w e5XpBbhtjBF7ptT2Q0lbFqct6ejI/7WdOOpwfMDIfZiRTTXF92TnjCd6rGKXAGTo0CmA fCvbOfLbmX3nJa+uYCG3WfBuZJpJ9Pf/YPvfcrpWiqIQ0NiKEGMfSP1ZVGolL0309EGI BvA6FRUGnID5uFPDEFQUF9uzCHZXqjycTdslGwhr3yFqTPaTU6WY8PLZInOhKNqNF5p/ sQ6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si11160425edj.233.2020.04.15.14.36.50; Wed, 15 Apr 2020 14:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389455AbgDNOSg (ORCPT + 99 others); Tue, 14 Apr 2020 10:18:36 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:3498 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389443AbgDNOSc (ORCPT ); Tue, 14 Apr 2020 10:18:32 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.11]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15e95c61edff-54dfc; Tue, 14 Apr 2020 22:18:09 +0800 (CST) X-RM-TRANSID: 2ee15e95c61edff-54dfc X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.3.208.246]) by rmsmtp-syy-appsvr06-12006 (RichMail) with SMTP id 2ee65e95c61f0fb-943a7; Tue, 14 Apr 2020 22:18:09 +0800 (CST) X-RM-TRANSID: 2ee65e95c61f0fb-943a7 From: Tang Bin To: minyard@acm.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, Tang Bin , Shengju Zhang Subject: [PATCH] ipmi:bt-bmc: Delete superfluous dev_warm() in bt_bmc_config_irq() Date: Tue, 14 Apr 2020 22:19:51 +0800 Message-Id: <20200414141951.19120-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The priority of dev_warm() is higher than dev_info(),so if the function bt_bmc_probe() uses dev_info() to print error message, the dev_warm() is redundant.Thus should be removed. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang --- drivers/char/ipmi/bt-bmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c index cd0349bff..1d4bf5c65 100644 --- a/drivers/char/ipmi/bt-bmc.c +++ b/drivers/char/ipmi/bt-bmc.c @@ -406,7 +406,6 @@ static int bt_bmc_config_irq(struct bt_bmc *bt_bmc, rc = devm_request_irq(dev, bt_bmc->irq, bt_bmc_irq, IRQF_SHARED, DEVICE_NAME, bt_bmc); if (rc < 0) { - dev_warn(dev, "Unable to request IRQ %d\n", bt_bmc->irq); bt_bmc->irq = 0; return rc; } -- 2.20.1.windows.1