Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Apr 2020 09:41:21 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Julien Thierry <jthierry@redhat.com>
Cc:     Matt Helsley <mhelsley@vmware.com>, linux-kernel@vger.kernel.org,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Miroslav Benes <mbenes@suse.cz>
Subject: Re: [RFC][PATCH 03/36] objtool: Enable compilation of objtool for
 all architectures
Message-ID: <20200414094121.73f5c82a@gandalf.local.home>
In-Reply-To: <e8a52162-dd38-6092-7217-cc5c088abadc@redhat.com>
References: <cover.1586468801.git.mhelsley@vmware.com>
        <a96d42818c7e8f2a8bd2e151b8c220193f4ae986.1586468801.git.mhelsley@vmware.com>
        <e8a52162-dd38-6092-7217-cc5c088abadc@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 14 Apr 2020 08:39:23 +0100
Julien Thierry <jthierry@redhat.com> wrote:

> My concern with this it that most of the structures and code in arch.h 
> and check.c can/should be reused across architectures. So, when 
> providing support for a new architecutre, the first thing that will be 
> needed is to move those back under tools/objtool whithout disturbing the 
> arches that don't yet provide support for "check" subcommand.

Are all the enums and structs in arch.h non-arch specific?

Or would they need to be split?

> 
> So, if it is decided that recordmcount should be an objtool subcommand, 
> the code itself should probably stay under tools/objtool and then have 
> different compilation configurations for objtool depending on the 
> architecture (e.g. HAVE_OBJTOOL_CHECK, HAVE_OBJTOOL_ORC) or something of 
> the sort.

That could work.

-- Steve