Message-ID: <4404C2E4.9070102@microgate.com>
Date: Tue, 28 Feb 2006 15:38:44 -0600
From: Paul Fulghum <paulkf@microgate.com>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
MIME-Version: 1.0
To: Alexey Dobriyan <adobriyan@gmail.com>
CC: Andrew Morton <akpm@osdl.org>, Darren Jenkins <darrenrjenkins@gmail.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] synclink_gt: make ->init_error signed
References: <20060228212619.GB7793@mipter.zuzino.mipt.ru>
In-Reply-To: <20060228212619.GB7793@mipter.zuzino.mipt.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 40

Alexey Dobriyan wrote:
> From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
> 
> Examples of misuse are
> 
> 3112 info->init_error = -1;
> 
> 4440 if ((info->init_error = register_test(info)) < 0) {
> 
> Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/char/synclink_gt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/char/synclink_gt.c
> +++ b/drivers/char/synclink_gt.c
> @@ -306,7 +306,7 @@ struct slgt_info {
>  	int tx_active;
>  
>  	unsigned char signals;    /* serial signal states */
> -	unsigned int init_error;  /* initialization error */
> +	int init_error;  /* initialization error */
>  
>  	unsigned char *tx_buf;
>  	int tx_count;

Yes, should definately by signed.

Acked-by: Paul Fulghum <paulkf@microgate.com>

-- 
Paul Fulghum
Microgate Systems, Ltd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/