Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp593444ybz; Wed, 15 Apr 2020 14:45:25 -0700 (PDT) X-Google-Smtp-Source: APiQypKNGP5m3amVdB1a+siJM2M7fXz//CgDLGjsaP5GTxtlNKrnaVxmKxDgeL48vUtJn+ncUjoO X-Received: by 2002:a17:906:7c2:: with SMTP id m2mr6313037ejc.339.1586987124919; Wed, 15 Apr 2020 14:45:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586987124; cv=none; d=google.com; s=arc-20160816; b=NVh4fVYJh5Eg9oOEI8YIoTbU9KiifQqnxx/5TSROJEPyp7A1OwkkLgsI0lLUOOlHu6 G008l/X89QC9GZ4IRYgeqleNRoqVCH0orYU6h5UC3eeh9p2IyaokOGmNf/qzohsrPRu1 iWNUxOsXaVZO4LTZkwfhb6qKHIvAOmGhDRMG99u4eehSKBLjtka3J7gtyMalE7k62TkE i78zB4oTHMUk8VG+9suwtYSrtXXP3j8W3NZjAKcby7wtoOhKtkc+cMKvmVg1kybeknX1 y4um6pEKR5S8qVK9OhCcHTLrsJTHUYAq2amoWKJLC1TFZEcD3GBA339+3/wjWrN7ZZ+d wmJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=/ckI4X6nNvf9S6wDHnOwFInQBrIZBWIoJvWviglbV+0=; b=S4ELW122hgnMzCN++X+CQ/YhbDxbZ5AFTM8fWxWsmFQ2FHeRMDpizqKYdXxZLnql7o E73TT7+5s5hkp8PPzsLBOTD3VzbQzUieCkmuZ0tyAukst7PqZulvnz3wzu8uMePqUYni /CDOhIKfpqY+jBE4aC/+XtJ9W59hY/733ZHDfGfl8bYxJfVYX9i7SnF2mQyjMzSA/Mmw 8hGdXjlFtDJrt1tqe7sIzZQAuQ4m6/vfmiLPBaI34X5rr4q8oFSv74QP7sgURkS8Gsz6 1MeY+K0AAPl84rK0diHsRF79tFefe0mF+Mr9KoEYOn1VzkJ4VTwy8U8WyhbYfXkSlYZh pb9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si10495645ejs.291.2020.04.15.14.45.02; Wed, 15 Apr 2020 14:45:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391325AbgDNQFv (ORCPT + 99 others); Tue, 14 Apr 2020 12:05:51 -0400 Received: from mga14.intel.com ([192.55.52.115]:55287 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390069AbgDNQFp (ORCPT ); Tue, 14 Apr 2020 12:05:45 -0400 IronPort-SDR: kDO3qiueyE/GCw0EtKVR/fyxiZ8px9gEY8yFKyj/8IbvU6au+wRNtXi0cVeNF/uq/4O5yniflf 7YHKnwDNVttw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 09:05:43 -0700 IronPort-SDR: 6IDIkU+SVDccdp2op//SqK8Ae8QZ0bITfXSpXqIGX1hAa1rYsIdE0ltjZfEPNCnBUFJJlPE+7A O2aRXmdOhGPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="298743363" Received: from shiyaowa-mobl.ger.corp.intel.com (HELO localhost) ([10.249.43.105]) by FMSMGA003.fm.intel.com with ESMTP; 14 Apr 2020 09:05:42 -0700 Date: Tue, 14 Apr 2020 19:05:41 +0300 From: Jarkko Sakkinen To: Ezra Buehler Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org, Tadeusz Struk , open list Subject: Re: [PATCH] selftests/tpm2: Change exception handling to be Python 3 compatible Message-ID: <20200414160541.GB32775@linux.intel.com> References: <20200412143656.72955-1-jarkko.sakkinen@linux.intel.com> <1FE03B4F-C42C-4B5F-A4B5-8169705911FA@easyb.ch> <20200412170719.GA324408@linux.intel.com> <531D50E8-E8FC-402E-9226-6000E8B6E960@easyb.ch> <20200413180440.GA10917@linux.intel.com> <20200414073806.GE8403@linux.intel.com> <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DDD1D36-9FCC-480A-978F-3BD08283DA03@easyb.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 01:14:11PM +0200, Ezra Buehler wrote: > On 14 Apr 2020, at 09:38, Jarkko Sakkinen wrote: > > OK, I'm aware about the dynamic nature but in this case it is somewhat > > counter intuitive since it is part of the exception clause. You'd except > > the Python interpreter to complain. > > I agree. > > > So, is Flake8 like the standard to be used? > > Pretty much, yes. There is also Pylint though. Among other things, they > both check for PEP 8 (official) coding style compliance. Thank you for taking time explaining all this. I'll make sure to include these to my process when I update my test from now on. /Jarkko