Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp598471ybz; Wed, 15 Apr 2020 14:52:09 -0700 (PDT) X-Google-Smtp-Source: APiQypIXpTAB/mBC7T8AZWEfSlOwDUtRHvLVFCjNJWMQo1l50X7j6ma6iA5VLV/+9J8e9Ts+p/q6 X-Received: by 2002:aa7:d344:: with SMTP id m4mr17037059edr.297.1586987529628; Wed, 15 Apr 2020 14:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586987529; cv=none; d=google.com; s=arc-20160816; b=NE6KtIP0050iTGSM6ISddyAtq29210k3C5SrtrD/32unRqBIjNNAef5umQVgjfoV2S A9hvbVmOnat8aQ65oucQ280oVDDdup75IxSTbsHNbK0DuFn2B0jtJo2K9lpYDY6LBgPD FXt0ONP5559GRHbNFatOUrFLoTjy92TlKf5fwyfVh8DI6eCWH+H8hckhX8glI5+t1Zeg fDSID7YBXIXvjFbj4CHPZA2cPm3wwnYwfQnEc8QN1aQ27aO0dEzzjMUvw/1Qhi/Yxy5K dlNmBA7seoVSnwqWrQFrWI52NdJcZsD/a9k1ZzU8b3vbsjMomX+D4AZxuRhBYxj5r7/G /bFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=q0tHRfEVRlAkMbOyvzMJJzg2LW/Cueq6j3gVJx/O50g=; b=rkJ37udCDAmzgKmCZ4K5zSVbo6IXBYdg1HOYDB7Lq7Sj5HcMRe65VcX9FI0FRj8Exw f5tqKNUl5Z6MvhX6l8v59cJQ9sB/zWK8SBE8YzfITf9zCcwmb0qHvwpF68v87CztPez4 tQwzn9OQ7UMr5CgPfOXsuCSAjBseNa3Ex14iclj+UPVYxwyySE2QyHm3NagroH7RNEA4 qCyQo4sm5GqgKgwHCn+fjs3UBuUTbuIqUXKhOttFPZv/LMUHVkHxX0RZWDYe18vwRjx3 aUGNn+B8/9e+lp3WvaGxfD1O+kp3x+Vc0Ud18CSrG0YapoRHURONItAYTrWZS74+4cF0 /hag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd13si11196490edb.199.2020.04.15.14.51.46; Wed, 15 Apr 2020 14:52:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504914AbgDNTfs (ORCPT + 99 others); Tue, 14 Apr 2020 15:35:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:45322 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504805AbgDNTfq (ORCPT ); Tue, 14 Apr 2020 15:35:46 -0400 IronPort-SDR: BBNag4/vldgH1A6t2E9Xw8IV8nUBrHeLJoh/rhwstwKu8DFYwU8T44+uqjP/rZWcHGT17vEcdb rytmZlYBcX2g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 12:35:45 -0700 IronPort-SDR: PdFZVdsop4wEI6kZ5uvPu49uwWNzttYDZCiEVJdjagXQLZy9j0X5G1FOz2eBNwHw/E3YIfFHTY cVdZQfx1tDBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,384,1580803200"; d="scan'208";a="253291808" Received: from jclobus-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.42.176]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2020 12:35:43 -0700 Date: Tue, 14 Apr 2020 22:35:42 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: Tianjia Zhang , "peterhuewe@gmx.de" , "jgg@ziepe.ca" , "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "zhang.jia@linux.alibaba.com" , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Silviu Vlasceanu Subject: Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend Message-ID: <20200414193542.GB13000@linux.intel.com> References: <20200414114226.96691-1-tianjia.zhang@linux.alibaba.com> <76d46ffbad294a6385779c29c4e5cafd@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76d46ffbad294a6385779c29c4e5cafd@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote: > > -----Original Message----- > > From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity- > > owner@vger.kernel.org] On Behalf Of Tianjia Zhang > > Sent: Tuesday, April 14, 2020 1:42 PM > > To: peterhuewe@gmx.de; jarkko.sakkinen@linux.intel.com; jgg@ziepe.ca; > > arnd@arndb.de; gregkh@linuxfoundation.org; zhang.jia@linux.alibaba.com > > Cc: linux-integrity@vger.kernel.org; linux-kernel@vger.kernel.org; > > tianjia.zhang@linux.alibaba.com > > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend > > > > For the algorithm that does not match the bank, a positive > > value EINVAL is returned here. I think this is a typo error. > > It is necessary to return an error value. > > Yes, thanks. > > Reviewed-by: Roberto Sassu Happen to have the commit ID at hand for fixes? Thanks. /Jarkko