Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp600356ybz; Wed, 15 Apr 2020 14:54:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKEPJZewosye1INEd5A2y7Arzq0iZ4WKj3OIyWi/GTk51w/41VYmCsWfkhFW/NSM8Q+uC1c X-Received: by 2002:a17:907:414d:: with SMTP id od21mr7272529ejb.178.1586987694141; Wed, 15 Apr 2020 14:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586987694; cv=none; d=google.com; s=arc-20160816; b=iYcKqCGhZPMj7a2myQxIHWF0VPrjkKR1homCqd96utX5CNdVboiXjxYXt3khuha4bY /pieBQ+WsrfURbgp54zXjOYsmFyUj2JQKp+Dp7ih+QlLiALNDpV7wuOmVIe9XncK0VCT Yw2NS1NCq9oq2SfpOYGqe80b4r66qqkFAcDh2/aMvdfaf9yP/P6gVp4eIN0IdhZIyexG AM9UN5ySSroRbOlrKG4zIDf3qDZZzUy86kYF54zqFGQjAkZUQI8CvaHuormbfiiS3sYc 0I1mOLJ3iC+C0bWGMW5O9PcS1PBi0f+XbJmNvAG2QyqmtZMPqiv8oDn6SxR9ePvHeN4T 7K3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=hgLxXEOZ9HPfPSKg+0bmnrtB7AkIqV2GrVwBsXdF8QM=; b=ln3XytxW+Mm8Mjdv5jALsWMx5K0Az9cXcuI/xT3xOMHIZ3QLXjHiTKlPWvuQCKXoKa NcAH+RWOnd/Ei297OJKcvTBZiRkPcHros4MmEptI71qDDkifLtduVML7t4Dm7OvmlQfP Jfw+qURmLMTXY2sxXAYQZ6o9Z9YmXXk8f2f6fSV5l2IM6yVlQJ/2dDqJcAHwajCtOun4 uwqcIOZj7BFNtX+++LAG7xF4xeehFnbmEG5RNWXafFmtK0dNOGzRwnFOyInIIkRI+rGN fk4wpcJxDkxeNpqCZevyxBw/sURbzINozetndez4DZe3QDi8V2bnXoIDZNJOXSiqJ2eu Qjeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 30si13515452edr.255.2020.04.15.14.54.31; Wed, 15 Apr 2020 14:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2632945AbgDNURO (ORCPT + 99 others); Tue, 14 Apr 2020 16:17:14 -0400 Received: from www62.your-server.de ([213.133.104.62]:54510 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2632798AbgDNUQU (ORCPT ); Tue, 14 Apr 2020 16:16:20 -0400 Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jORVK-0002Ww-MB; Tue, 14 Apr 2020 21:45:54 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jORVK-000AlG-9Q; Tue, 14 Apr 2020 21:45:54 +0200 Subject: Re: [PATCH-next] bpf: Verifier, remove unneeded conversion to bool To: Zou Wei , ast@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <1586779076-101346-1-git-send-email-zou_wei@huawei.com> From: Daniel Borkmann Message-ID: Date: Tue, 14 Apr 2020 21:45:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1586779076-101346-1-git-send-email-zou_wei@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25782/Tue Apr 14 13:57:42 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/13/20 1:57 PM, Zou Wei wrote: > This issue was detected by using the Coccinelle software: > > kernel/bpf/verifier.c:1259:16-21: WARNING: conversion to bool not needed here > > The conversion to bool is unneeded, remove it > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei Applied, thanks!