Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5E966604.1020400@cn.fujitsu.com>
Date:   Wed, 15 Apr 2020 09:40:20 +0800
From:   Xiao Yang <yangx.jy@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.2; zh-CN; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To:     Markus Elfring <Markus.Elfring@web.de>
CC:     <linux-kselftest@vger.kernel.org>,
        <linux-trace-devel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Xiao Yang <ice_yangxiao@163.com>
Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot'
 event trigger and triggering 'snapshot' operation
References: <f4e4614b-e3df-e255-42d0-1148e39b3f8a@web.de>
In-Reply-To: <f4e4614b-e3df-e255-42d0-1148e39b3f8a@web.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/4/14 15:54, Markus Elfring wrote:
>> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()
>
> I suggest to improve the change description.
>
> * Adjustment:
>    … operation (i. e. …
Hi Markus,

Which part of description do you want to change or could you provide an 
example for reference?

>
> * Will the tag “Fixes” become relevant?

Do you mean to add the following "Fixes" tag?
Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"

Thanks,
Xiao Yang
>
> Regards,
> Markus
>
>
> .
>