Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Apr 2020 21:46:42 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc:     Markus Elfring <Markus.Elfring@web.de>,
        <linux-kselftest@vger.kernel.org>,
        <linux-trace-devel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Xiao Yang <ice_yangxiao@163.com>
Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot'
 event trigger and triggering 'snapshot' operation
Message-ID: <20200414214643.2e14ac76@oasis.local.home>
In-Reply-To: <5E966604.1020400@cn.fujitsu.com>
References: <f4e4614b-e3df-e255-42d0-1148e39b3f8a@web.de>
        <5E966604.1020400@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 15 Apr 2020 09:40:20 +0800
Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:

> On 2020/4/14 15:54, Markus Elfring wrote:
> >> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()  
> >
> > I suggest to improve the change description.
> >
> > * Adjustment:
> >    … operation (i. e. …  
> Hi Markus,
> 
> Which part of description do you want to change or could you provide an 
> example for reference?

That part is fine for me.

> 
> >
> > * Will the tag “Fixes” become relevant?  
> 
> Do you mean to add the following "Fixes" tag?
> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
> 

Yeah, that fixes tag is appropriate. But I usually add those myself, you
don't need to resend.

-- Steve