Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp607621ybz; Wed, 15 Apr 2020 15:03:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJroCWc9zRnP46leDtZSyO5OW0mO/VMyuwDizO9WzZQm9pqRT+6YOIWRDqVZj7T7iIZtzQE X-Received: by 2002:a50:f699:: with SMTP id d25mr26995220edn.244.1586988205267; Wed, 15 Apr 2020 15:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586988205; cv=none; d=google.com; s=arc-20160816; b=iO/B/rQ/2YRtA2SkwzRZIoNn0tK3xUQi3DO+IOeYKprlBUJN7zNMSQjwJLafc+i5Wf mKqGlV7mBseHfEzAhkIUIXKkvSBuAOU89Ma4gSrMD4p2FlwSAJHFhOtMeezW5kgCqGE2 UvPFEODfGCx5QvEbso74IzQyzWXoBDI55UplefvLC8f1jHGd1f8yN3IMniVfURI8kpFj gLW9E4DOkfkxLNXO7G+hlM96Bl1wdmB89Jt3NqJ1J3OpM/15WRymc1KS4tVHHRtbgvIq XLJbx6S4VkokQbLrYdJDgDJ5iYLHLbJ00ohNb9HcMta07SM28DCSLby+BNXNW5hSwD8R pgkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=efn438GMqUgUipse02wdiGSVnUXiFi6JBFEUw6vzsJ0=; b=Ayf3y6F4U8dNuLPrZstJOylGjNWhunpxeTDSeKCL6X3J1XjxLx5KET5IiQ1cjmTHr1 5tofyhmqSGLYEKUZ270X4NJNR+1+HdVvO6fj6BCtocCgeW963QF0zME2PLVosUj17w9I /VCyPw9wiP9loOTCy4vf9dCd0LqQP/0dNlz0RH1ZrAn4VK4kaPX0Qzx8uOuQRv7sX7oD zEmFE8GD4GlyjhOxhH+sYG7+cpfom5MWM5NQMmBwralD7R5CfQ6lZo1x6yqhT9Vz+Jiy MNRgea1BeAZqoEYyN19eXoT4bk57/lAOja3x1V/xDC4kb63bdCVhbIML5cKFPKSmSNn9 rEBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si11890468edm.374.2020.04.15.15.02.57; Wed, 15 Apr 2020 15:03:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392649AbgDOBhX (ORCPT + 99 others); Tue, 14 Apr 2020 21:37:23 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:41814 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733236AbgDOBhQ (ORCPT ); Tue, 14 Apr 2020 21:37:16 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 80AE34BA1B1AFC66BAA2; Wed, 15 Apr 2020 09:37:13 +0800 (CST) Received: from [127.0.0.1] (10.173.223.60) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Wed, 15 Apr 2020 09:37:09 +0800 Subject: Re: [PATCH -next] bpf: remove set but not used variable 'dst_known' To: Song Liu CC: Alexei Starovoitov , Daniel Borkmann , Martin Lau , Yonghong Song , Andrii Nakryiko , "john.fastabend@gmail.com" , "kpsingh@chromium.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" References: <20200413113703.194287-1-maowenan@huawei.com> From: maowenan Message-ID: <2b2e0060-ef9b-5541-1108-e28464b47f0a@huawei.com> Date: Wed, 15 Apr 2020 09:37:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.223.60] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 6:05, Song Liu wrote: > > >> On Apr 13, 2020, at 4:37 AM, Mao Wenan wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> kernel/bpf/verifier.c:5603:18: warning: variable ‘dst_known’ >> set but not used [-Wunused-but-set-variable] >> >> It is not used since commit f1174f77b50c ("bpf/verifier: >> rework value tracking") > > The fix makes sense. But I think f1174f77b50c introduced dst_known, > so this statement is not accurate. > thanks for review, yes, f1174f77b50c introduced dst_known, and below commit doesn't deference variable dst_known. So I send v2 later? 3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking") >> >> Signed-off-by: Mao Wenan >