Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp615726ybz; Wed, 15 Apr 2020 15:12:03 -0700 (PDT) X-Google-Smtp-Source: APiQypI1MUTHOTGE0ajgRZo01txdZdGO5cOLPRju49QgtXBCqnQcGLl4WdUjxREFEh4l/UqTHKaO X-Received: by 2002:a17:906:d1c4:: with SMTP id bs4mr6955874ejb.109.1586988723541; Wed, 15 Apr 2020 15:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586988723; cv=none; d=google.com; s=arc-20160816; b=Zvv97lKPn8as8yj/4Ks8t+rCA/l7y7sNS4zbWM/IOCvybHlUs6Sqb1iFABrmr5Pmpg qyR/eFpwxazj/xj8CmKB0jrNpZaLSg1BmkAuj+ETofjPJ8qz05GUqaDi+5p1Fv/1b2IK HLJAW6oaDkSUHmR93r6x9k6PoNepvd6FPD98WOyRHTn91wXBbjEGumvbw1BPQP0qOvTe CRun8OLVubZyKNFUSw9Szz6PigdbAx7vkMfdFFjVcMQdsgmcurq8wOQGgtN8PLe3klzG Oza3Q1AaQgNHBe3CzD33k5C8cvTSJ7YRwIdxd+glSMpD21s2aheGyaN3Mq3wy6Xwx7lH S+Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=nw6hujR3MdnKl3uIqx+HUzxonsmT/n8kcsBPE/R1pes=; b=W1yiZkMLo0Dn6fT2Ev44LsFQlqyAdtzP6b6oTDBVsXYI2tNsVBbIPmSnngeMweHj/V yB6A0bwAmsVGnhbsVfFpQWH4mSUnDQ2u6Nc4ocxXiGjN2wxYkEAqqehCrxgGQfKIN9WE w/KUh0obDfUphVGSWhqhTnltXJwG+okyTwz5AgFA0N6a+V+eTpPJdBlxDV6DC1L0a0Ee bBDpWjMN6KHaDmUZqLYkalyC7vPtbVb9bWWix1W7EIIvH3K9xPVj06XOKObAcHiX4xDE K5Ndhf4fkJDNiP5Uj4cuVQdglwXZ6GAtc89rogW/t0NqO8Y25w4X730FephcG3+SNoRe GCLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rv23si9698752ejb.330.2020.04.15.15.11.40; Wed, 15 Apr 2020 15:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634851AbgDOG0C (ORCPT + 99 others); Wed, 15 Apr 2020 02:26:02 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:37270 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2634828AbgDOGZ6 (ORCPT ); Wed, 15 Apr 2020 02:25:58 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 80110417E13B5D4CF896; Wed, 15 Apr 2020 14:25:56 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.210) with Microsoft SMTP Server (TLS) id 14.3.487.0; Wed, 15 Apr 2020 14:25:53 +0800 Subject: Re: [PATCH] f2fs: report the discard cmd errors properly To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1586923554-30257-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Wed, 15 Apr 2020 14:25:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1586923554-30257-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 12:05, Sahitya Tummala wrote: > In case a discard_cmd is split into several bios, the dc->error > must not be overwritten once an error is reported by a bio. Also, > move it under dc->lock. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,